colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mm-bearer-mbim: fix connect_set_ready always parse result for needing to check NwError on failure

Browse Source 
Issue and bugfix suggestion by Aleksander Morgado.

Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/549
This commit is contained in:
Jack Song
2022-05-07 16:20:08 +08:00
committed by Aleksander Morgado
parent 82b574a6e7
commit 0c67d93edd
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/mm-bearer-mbim.c
View File

@@ -614,14 +614,15 @@ connect_set_ready (MbimDevice *device,
ctx = g_task_get_task_data (task);
response = mbim_device_command_finish (device, res, &error);
if (!response ||
(!mbim_message_response_get_result (response, MBIM_MESSAGE_TYPE_COMMAND_DONE, &error) &&
(error->code != MBIM_STATUS_ERROR_FAILURE))) {
if (!response) {
g_task_return_error (task, error);
g_object_unref (task);
return;
}
/* always parse, because on failure we also check the NwError */
mbim_message_response_get_result (response, MBIM_MESSAGE_TYPE_COMMAND_DONE, &error);
if (mbim_device_check_ms_mbimex_version (device, 3, 0)) {
if (!mbim_message_ms_basic_connect_v3_connect_response_parse (
response,