colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

broadband-modem-mbim: Set InitialEPSBearer's authentication to CHAP when is UNKNOWN

Browse Source 
This is the same behavior that is used when creating the bearer in
mm-bearer-mbim.
This commit is contained in:
Andrew Lassalle
2022-03-09 12:06:52 -08:00
committed by Aleksander Morgado
parent 9793378870
commit 0fbab3c8dc
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/mm-broadband-modem-mbim.c
View File

@@ -3980,18 +3980,6 @@ before_set_lte_attach_configuration_query_ready (MbimDevice *device,
} }
} }
auth = mm_bearer_properties_get_allowed_auth (config);
if (auth == MM_BEARER_ALLOWED_AUTH_UNKNOWN)
configurations[i]->auth_protocol = MBIM_AUTH_PROTOCOL_NONE;
else {
configurations[i]->auth_protocol = mm_bearer_allowed_auth_to_mbim_auth_protocol (auth, self, &error);
if (error) {
configurations[i]->auth_protocol = MBIM_AUTH_PROTOCOL_NONE;
mm_obj_warn (self, "unexpected auth settings requested: %s", error->message);
g_clear_error (&error);
}
}
g_clear_pointer (&(configurations[i]->access_string), g_free); g_clear_pointer (&(configurations[i]->access_string), g_free);
configurations[i]->access_string = g_strdup (mm_bearer_properties_get_apn (config)); configurations[i]->access_string = g_strdup (mm_bearer_properties_get_apn (config));
@@ -4001,6 +3989,18 @@ before_set_lte_attach_configuration_query_ready (MbimDevice *device,
g_clear_pointer (&(configurations[i]->password), g_free); g_clear_pointer (&(configurations[i]->password), g_free);
configurations[i]->password = g_strdup (mm_bearer_properties_get_password (config)); configurations[i]->password = g_strdup (mm_bearer_properties_get_password (config));
auth = mm_bearer_properties_get_allowed_auth (config);
if ((auth != MM_BEARER_ALLOWED_AUTH_UNKNOWN) || configurations[i]->user_name || configurations[i]->password) {
configurations[i]->auth_protocol = mm_bearer_allowed_auth_to_mbim_auth_protocol (auth, self, &error);
if (error) {
configurations[i]->auth_protocol = MBIM_AUTH_PROTOCOL_NONE;
mm_obj_warn (self, "unexpected auth settings requested: %s", error->message);
g_clear_error (&error);
}
} else {
configurations[i]->auth_protocol = MBIM_AUTH_PROTOCOL_NONE;
}
configurations[i]->source = MBIM_CONTEXT_SOURCE_USER; configurations[i]->source = MBIM_CONTEXT_SOURCE_USER;
configurations[i]->compression = MBIM_COMPRESSION_NONE; configurations[i]->compression = MBIM_COMPRESSION_NONE;
break; break;