colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

broadband-modem-mbim: non-zero interval when enabling thresholds

Browse Source 
Fix bug in Fibocom FM350 modem where a non-zero signal strength
interval needs to be configured as part of threshold setup.

Fixes #733
This commit is contained in:
Aleksander Morgado
2023-05-11 11:13:35 +00:00
parent ecea0a16e1
commit 1564b54cff
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/mm-broadband-modem-mbim.c
View File

@@ -6850,8 +6850,13 @@ modem_signal_setup_thresholds (MMIfaceModemSignal *self,
if (error_rate_threshold) if (error_rate_threshold)
coded_error_rate_threshold = 1; /* minimum value when enabled */ coded_error_rate_threshold = 1; /* minimum value when enabled */
/* setting signal strength interval to 0 disables threshold-based
* notifications on certain modems (FM350).
* hence, it is being set to 5 as per FBC's recommendation.
* typically, setting this parameter to 0 should make the modem
* set the value to its internal default as per spec. */
message = (mbim_message_signal_state_set_new ( message = (mbim_message_signal_state_set_new (
0, /* signal strength interval set to default always */ 5, /* non-zero default signal strength interval */
coded_rssi_threshold, coded_rssi_threshold,
coded_error_rate_threshold, coded_error_rate_threshold,
NULL)); NULL));