iface-modem-messaging: fix warnings with -Wimplicit-fallthrough
mm-iface-modem-messaging.c: In function ‘interface_disabling_step’: mm-iface-modem-messaging.c:615:18: error: this statement may fall through [-Werror=implicit-fallthrough=] 615 | ctx->step++; | ~~~~~~~~~^~ mm-iface-modem-messaging.c:617:5: note: here 617 | case DISABLING_STEP_DISABLE_UNSOLICITED_EVENTS: | ^~~~ ...
This commit is contained in:
@@ -611,8 +611,8 @@ interface_disabling_step (GTask *task)
|
|||||||
|
|
||||||
switch (ctx->step) {
|
switch (ctx->step) {
|
||||||
case DISABLING_STEP_FIRST:
|
case DISABLING_STEP_FIRST:
|
||||||
/* Fall down to next step */
|
|
||||||
ctx->step++;
|
ctx->step++;
|
||||||
|
/* fall through */
|
||||||
|
|
||||||
case DISABLING_STEP_DISABLE_UNSOLICITED_EVENTS:
|
case DISABLING_STEP_DISABLE_UNSOLICITED_EVENTS:
|
||||||
/* Allow cleaning up unsolicited events */
|
/* Allow cleaning up unsolicited events */
|
||||||
@@ -624,8 +624,8 @@ interface_disabling_step (GTask *task)
|
|||||||
task);
|
task);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
/* Fall down to next step */
|
|
||||||
ctx->step++;
|
ctx->step++;
|
||||||
|
/* fall through */
|
||||||
|
|
||||||
case DISABLING_STEP_CLEANUP_UNSOLICITED_EVENTS:
|
case DISABLING_STEP_CLEANUP_UNSOLICITED_EVENTS:
|
||||||
/* Allow cleaning up unsolicited events */
|
/* Allow cleaning up unsolicited events */
|
||||||
@@ -637,8 +637,8 @@ interface_disabling_step (GTask *task)
|
|||||||
task);
|
task);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
/* Fall down to next step */
|
|
||||||
ctx->step++;
|
ctx->step++;
|
||||||
|
/* fall through */
|
||||||
|
|
||||||
case DISABLING_STEP_LAST:
|
case DISABLING_STEP_LAST:
|
||||||
/* Clear SMS list */
|
/* Clear SMS list */
|
||||||
@@ -958,9 +958,8 @@ interface_enabling_step (GTask *task)
|
|||||||
|
|
||||||
g_object_unref (list);
|
g_object_unref (list);
|
||||||
|
|
||||||
/* Fall down to next step */
|
|
||||||
ctx->step++;
|
ctx->step++;
|
||||||
}
|
} /* fall through */
|
||||||
|
|
||||||
case ENABLING_STEP_SETUP_SMS_FORMAT:
|
case ENABLING_STEP_SETUP_SMS_FORMAT:
|
||||||
/* Allow setting SMS format to use */
|
/* Allow setting SMS format to use */
|
||||||
@@ -972,8 +971,8 @@ interface_enabling_step (GTask *task)
|
|||||||
task);
|
task);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
/* Fall down to next step */
|
|
||||||
ctx->step++;
|
ctx->step++;
|
||||||
|
/* fall through */
|
||||||
|
|
||||||
case ENABLING_STEP_STORAGE_DEFAULTS: {
|
case ENABLING_STEP_STORAGE_DEFAULTS: {
|
||||||
MMSmsStorage default_storage;
|
MMSmsStorage default_storage;
|
||||||
@@ -1001,9 +1000,8 @@ interface_enabling_step (GTask *task)
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Fall down to next step */
|
|
||||||
ctx->step++;
|
ctx->step++;
|
||||||
}
|
} /* fall through */
|
||||||
|
|
||||||
case ENABLING_STEP_LOAD_INITIAL_SMS_PARTS:
|
case ENABLING_STEP_LOAD_INITIAL_SMS_PARTS:
|
||||||
/* Allow loading the initial list of SMS parts */
|
/* Allow loading the initial list of SMS parts */
|
||||||
@@ -1012,8 +1010,8 @@ interface_enabling_step (GTask *task)
|
|||||||
load_initial_sms_parts_from_storages (task);
|
load_initial_sms_parts_from_storages (task);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
/* Fall down to next step */
|
|
||||||
ctx->step++;
|
ctx->step++;
|
||||||
|
/* fall through */
|
||||||
|
|
||||||
case ENABLING_STEP_SETUP_UNSOLICITED_EVENTS:
|
case ENABLING_STEP_SETUP_UNSOLICITED_EVENTS:
|
||||||
/* Allow setting up unsolicited events */
|
/* Allow setting up unsolicited events */
|
||||||
@@ -1025,8 +1023,8 @@ interface_enabling_step (GTask *task)
|
|||||||
task);
|
task);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
/* Fall down to next step */
|
|
||||||
ctx->step++;
|
ctx->step++;
|
||||||
|
/* fall through */
|
||||||
|
|
||||||
case ENABLING_STEP_ENABLE_UNSOLICITED_EVENTS:
|
case ENABLING_STEP_ENABLE_UNSOLICITED_EVENTS:
|
||||||
/* Allow setting up unsolicited events */
|
/* Allow setting up unsolicited events */
|
||||||
@@ -1038,8 +1036,8 @@ interface_enabling_step (GTask *task)
|
|||||||
task);
|
task);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
/* Fall down to next step */
|
|
||||||
ctx->step++;
|
ctx->step++;
|
||||||
|
/* fall through */
|
||||||
|
|
||||||
case ENABLING_STEP_LAST:
|
case ENABLING_STEP_LAST:
|
||||||
/* We are done without errors! */
|
/* We are done without errors! */
|
||||||
@@ -1282,8 +1280,8 @@ interface_initialization_step (GTask *task)
|
|||||||
supported_quark = (g_quark_from_static_string (
|
supported_quark = (g_quark_from_static_string (
|
||||||
SUPPORTED_TAG));
|
SUPPORTED_TAG));
|
||||||
|
|
||||||
/* Fall down to next step */
|
|
||||||
ctx->step++;
|
ctx->step++;
|
||||||
|
/* fall through */
|
||||||
|
|
||||||
case INITIALIZATION_STEP_CHECK_SUPPORT:
|
case INITIALIZATION_STEP_CHECK_SUPPORT:
|
||||||
if (!GPOINTER_TO_UINT (g_object_get_qdata (G_OBJECT (self),
|
if (!GPOINTER_TO_UINT (g_object_get_qdata (G_OBJECT (self),
|
||||||
@@ -1309,8 +1307,8 @@ interface_initialization_step (GTask *task)
|
|||||||
/* If there is no implementation to check support, assume we DON'T
|
/* If there is no implementation to check support, assume we DON'T
|
||||||
* support it. */
|
* support it. */
|
||||||
}
|
}
|
||||||
/* Fall down to next step */
|
|
||||||
ctx->step++;
|
ctx->step++;
|
||||||
|
/* fall through */
|
||||||
|
|
||||||
case INITIALIZATION_STEP_FAIL_IF_UNSUPPORTED:
|
case INITIALIZATION_STEP_FAIL_IF_UNSUPPORTED:
|
||||||
if (!GPOINTER_TO_UINT (g_object_get_qdata (G_OBJECT (self),
|
if (!GPOINTER_TO_UINT (g_object_get_qdata (G_OBJECT (self),
|
||||||
@@ -1322,8 +1320,8 @@ interface_initialization_step (GTask *task)
|
|||||||
g_object_unref (task);
|
g_object_unref (task);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
/* Fall down to next step */
|
|
||||||
ctx->step++;
|
ctx->step++;
|
||||||
|
/* fall through */
|
||||||
|
|
||||||
case INITIALIZATION_STEP_LOAD_SUPPORTED_STORAGES:
|
case INITIALIZATION_STEP_LOAD_SUPPORTED_STORAGES:
|
||||||
if (MM_IFACE_MODEM_MESSAGING_GET_INTERFACE (self)->load_supported_storages &&
|
if (MM_IFACE_MODEM_MESSAGING_GET_INTERFACE (self)->load_supported_storages &&
|
||||||
@@ -1334,8 +1332,8 @@ interface_initialization_step (GTask *task)
|
|||||||
task);
|
task);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
/* Fall down to next step */
|
|
||||||
ctx->step++;
|
ctx->step++;
|
||||||
|
/* fall through */
|
||||||
|
|
||||||
case INITIALIZATION_STEP_INIT_CURRENT_STORAGES:
|
case INITIALIZATION_STEP_INIT_CURRENT_STORAGES:
|
||||||
if (MM_IFACE_MODEM_MESSAGING_GET_INTERFACE (self)->init_current_storages &&
|
if (MM_IFACE_MODEM_MESSAGING_GET_INTERFACE (self)->init_current_storages &&
|
||||||
@@ -1346,8 +1344,8 @@ interface_initialization_step (GTask *task)
|
|||||||
task);
|
task);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
/* Fall down to next step */
|
|
||||||
ctx->step++;
|
ctx->step++;
|
||||||
|
/* fall through */
|
||||||
|
|
||||||
case INITIALIZATION_STEP_LAST:
|
case INITIALIZATION_STEP_LAST:
|
||||||
/* We are done without errors! */
|
/* We are done without errors! */
|
||||||
|
Reference in New Issue
Block a user