colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

plugins,telit: do not crash if revision is not set

Browse Source 
In mm_telit_model_from_revision there is nothing that prevents to use
the input revision string if it is NULL, which currently happens if
the modem is pure MBIM (i.e. LE910-V2 pid:0x0032).

Fix the above error returning a default safe value and not using the
NULL variable.
This commit is contained in:
Carlo Lobrano
2022-06-08 15:34:49 +02:00
committed by Aleksander Morgado
parent 3da84c2079
commit 19a0ea6cf9
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
plugins/telit/mm-modem-helpers-telit.c
View File

@@ -943,7 +943,8 @@ mm_telit_model_from_revision (const gchar *revision)
{"40.", MM_TELIT_MODEL_LN920} {"40.", MM_TELIT_MODEL_LN920}
}; };
g_assert (revision); if (!revision)
return MM_TELIT_MODEL_DEFAULT;
for (i = 0; i < G_N_ELEMENTS (revision_to_model_map); ++i) { for (i = 0; i < G_N_ELEMENTS (revision_to_model_map); ++i) {
if (g_str_has_prefix (revision, revision_to_model_map[i].revision_prefix)) if (g_str_has_prefix (revision, revision_to_model_map[i].revision_prefix))