colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

modem-helpers: fix warnings with -Wsign-compare

Browse Source 
mm-modem-helpers.c: In function ‘parse_uint’:
  mm-modem-helpers.c:1953:36: error: comparison of integer expressions of different signedness: ‘gulong’ {aka ‘long unsigned int’} and ‘glong’ {aka ‘long int’} [-Werror=sign-compare]
   1953 |         if ((nmin == nmax) || (ret >= nmin && ret <= nmax))
        |                                    ^~
  mm-modem-helpers.c:1953:51: error: comparison of integer expressions of different signedness: ‘gulong’ {aka ‘long unsigned int’} and ‘glong’ {aka ‘long int’} [-Werror=sign-compare]
   1953 |         if ((nmin == nmax) || (ret >= nmin && ret <= nmax))
        |                                                   ^~
This commit is contained in:
Aleksander Morgado
2020-01-11 13:46:34 +01:00
parent 02e5015b5c
commit 1f94d3f5f8
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/mm-modem-helpers.c
View File

@@ -1932,7 +1932,11 @@ mm_3gpp_parse_cgact_read_response (const gchar *reply,
/*************************************************************************/
static gulong
parse_uint (char *str, int base, glong nmin, glong nmax, gboolean *valid)
parse_uint (gchar *str,
gint base,
gulong nmin,
gulong nmax,
gboolean *valid)
{
gulong ret = 0;
gchar *endquote;
@@ -4677,7 +4681,7 @@ mm_cdma_parse_eri (const gchar *reply,
*out_ind = ind;
while (iter->num != -1) {
if (iter->num == ind) {
if ((guint)iter->num == ind) {
*out_roaming = iter->roam_ind;
if (out_desc)
*out_desc = iter->banner;