From d4b2be5f6b1a2e4e203dc6038bf31e63e4d80670 Mon Sep 17 00:00:00 2001
From: David Rochberg <rochberg@chromium.org>
Date: Mon, 11 Oct 2010 17:14:32 -0400
Subject: [PATCH 1/2] Replace ActivationCompleted with ActivationStateChanged,
 add CDMA error enums.

BUG=6885
TEST=mm-modem.h is correct, cromo compiles

Change-Id: I2b6a49bda5a6ff7bf6e4aac2e99914bf3c33c732

Review URL: http://codereview.chromium.org/3705001

Review URL: http://codereview.chromium.org/3702006
---
 ...rg.freedesktop.ModemManager.Modem.Cdma.xml | 79 ++++++++++++++++++-
 1 file changed, 77 insertions(+), 2 deletions(-)

diff --git a/introspection/org.freedesktop.ModemManager.Modem.Cdma.xml b/introspection/org.freedesktop.ModemManager.Modem.Cdma.xml
index fd6a4d3d..3e4c98b7 100644
--- a/introspection/org.freedesktop.ModemManager.Modem.Cdma.xml
+++ b/introspection/org.freedesktop.ModemManager.Modem.Cdma.xml
@@ -5,7 +5,9 @@
 
     <method name="Activate">
       <tp:docstring>
-        Activates the modem for use with a given carrier.
+        Activates the modem for use with a given carrier.  In the
+        event of immediate failure, returns an error value instead of
+        setting a DBus error.
       </tp:docstring>
       <annotation name="org.freedesktop.DBus.GLib.Async" value=""/>
       <annotation name="org.freedesktop.DBus.GLib.CSymbol" value="impl_modem_cdma_activate"/>
@@ -14,6 +16,13 @@
           Name of carrier.
         </tp:docstring>
       </arg>
+      <arg name="immediate_error" type="u" direction="out">
+        <tp:docstring>
+          An enum from MM_MODEM_CDMA_ACTIVATION_ERROR.  This is
+          returned for immediate errors.  Delayed errors are returned
+          via an ActivationStateChanged signal
+        </tp:docstring>
+      </arg>
     </method>
 
     <method name="ActivateManual">
@@ -31,6 +40,24 @@
       </arg>
     </method>
 
+    <signal name="ActivationStateChanged">
+      <tp:docstring>
+	    The device activation state changed.
+      </tp:docstring>
+      <arg name="activation_state" type="u" tp:type="MM_MODEM_CDMA_ACTIVATION_STATE">
+        <tp:docstring>Current activation state</tp:docstring>
+      </arg>
+      <arg name="activation_error" type="u" tp:type="MM_MODEM_CDMA_ACTIVATION_ERROR">
+        <tp:docstring>Carrier-specific error code</tp:docstring>
+      </arg>
+      <arg name="status_changes" type="a{sv}">
+        <tp:docstring>Selected Modem.Simple.GetStatus keys that have changed as a
+          result of this activation state change.  Will include 'mdn'
+          and 'min'.
+        </tp:docstring>
+      </arg>
+    </signal>
+
     <method name="GetSignalQuality">
       <tp:docstring>
 	Get the current signal quality.
@@ -140,6 +167,54 @@
         <tp:docstring>Device is ready for use.</tp:docstring>
       </tp:enumvalue>
     </tp:enum>
+
+    <tp:enum name="MM_MODEM_CDMA_ACTIVATION_ERROR" type="u">
+      <tp:enumvalue suffix="NO_ERROR" value="0"/>
+      <tp:enumvalue suffix="ROAMING" value="1">
+        <tp:docstring>
+          Device cannot activate while roaming.
+        </tp:docstring>
+      </tp:enumvalue>
+      <tp:enumvalue suffix="WRONG_RADIO_INTERFACE" value="2">
+        <tp:docstring>
+          Device cannot activate on this network type (eg EVDO vs 1xRTT).
+        </tp:docstring>
+      </tp:enumvalue>
+      <tp:enumvalue suffix="COULD_NOT_CONNECT" value="3">
+        <tp:docstring>
+          Device could not connect to the network for activation.
+        </tp:docstring>
+      </tp:enumvalue>
+      <tp:enumvalue suffix="SECURITY_AUTHENTICATION_FAILED" value="4">
+        <tp:docstring>
+          Device could not authenticate to the network for activation.
+        </tp:docstring>
+      </tp:enumvalue>
+      <tp:enumvalue suffix="PROVISIONING_FAILED" value="5">
+        <tp:docstring>
+          Later stages of device provisioning failed.
+        </tp:docstring>
+      </tp:enumvalue>
+      <tp:enumvalue suffix="NO_SIGNAL" value="6">
+        <tp:docstring>
+          No signal available.
+        </tp:docstring>
+      </tp:enumvalue>
+      <tp:enumvalue suffix="UNKNOWN" value="7">
+        <tp:docstring>
+          An error occurred.
+        </tp:docstring>
+      </tp:enumvalue>
+      <tp:enumvalue suffix="TIMED_OUT" value="8">
+        <tp:docstring>
+          Activation timed out.
+        </tp:docstring>
+      </tp:enumvalue>
+      <tp:enumvalue suffix="START_FAILED" value="9">
+        <tp:docstring>
+          API call for initial activation failed.
+        </tp:docstring>
+      </tp:enumvalue>
+    </tp:enum>
   </interface>
 </node>
-

From f047ca66a4c58bdfa69ce70026fc840d58a80ebe Mon Sep 17 00:00:00 2001
From: Elly Jones <ellyjones@google.com>
Date: Wed, 15 Sep 2010 13:22:25 -0400
Subject: [PATCH 2/2] modemmanager: Add a reason to ConnectionStateChanged
 events.

This can be used by a connection manager to decide to respond in a different way
to certain kinds of disconnects (e.g. intentional versus unintentional versus
suspension).

TEST=None
This change introduces no additional code, so testing it in isolation is not
possible.

BUG=chromium-os:6744

Change-Id: Ie371e20ec7a003333eba013af3ad61c0e494a4ad
Signed-Off-By: Elly Jones <ellyjones@chromium.org>

Review URL: http://codereview.chromium.org/3413011
(cherry picked from commit 29a9674b818fd64c19bad84f526f6fa68edec174)
---
 .../org.freedesktop.ModemManager.Modem.xml    | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/introspection/org.freedesktop.ModemManager.Modem.xml b/introspection/org.freedesktop.ModemManager.Modem.xml
index 1c032aa6..e1a07293 100644
--- a/introspection/org.freedesktop.ModemManager.Modem.xml
+++ b/introspection/org.freedesktop.ModemManager.Modem.xml
@@ -93,6 +93,11 @@
           Reason for state transition.
         </tp:docstring>
       </arg>
+      <arg name="reason" type="u" tp:type="MM_MODEM_CONNECTION_STATE_CHANGED_REASON">
+        <tp:docstring>
+          Reason for this state change.
+        </tp:docstring>
+      </arg>
     </signal>
 
     <property name="Device" type="s" access="read">
@@ -211,5 +216,24 @@
       </tp:enumvalue>
     </tp:enum>
 
+    <tp:enum name="MM_MODEM_CONNECTION_STATE_CHANGE_REASON" type="u">
+      <tp:enumvalue suffix="UNKNOWN" value="0">
+        <tp:docstring>
+          Reason unknown or not reportable.
+        </tp:docstring>
+      </tp:enumvalue>
+      <tp:enumvalue suffix="REQUESTED" value="1">
+        <tp:docstring>
+          Connection state change was requested by an interface user.
+        </tp:docstring>
+      </tp:enumvalue>
+      <tp:enumvalue suffix="SUSPEND" value="2">
+        <tp:docstring>
+          Connection state change was caused by a system suspend.
+        </tp:docstring>
+      </tp:enumvalue>
+    </tp:enum>
+
+
   </interface>
 </node>