core: add index to CIND helper

src/mm-modem-helpers.c

@@ -888,17 +888,19 @@ mm_create_device_identifier (guint vid,
 
 struct CindResponse {
     char *desc;
+    gint idx;
     gint min;
     gint max;
 };
 
 static CindResponse *
-cind_response_new (const char *desc, gint min, gint max)
+cind_response_new (const char *desc, gint idx, gint min, gint max)
 {
     CindResponse *r;
     char *p;
 
     g_return_val_if_fail (desc != NULL, NULL);
+    g_return_val_if_fail (idx >= 0, NULL);
 
     r = g_malloc0 (sizeof (CindResponse));
 
@@ -910,6 +912,7 @@ cind_response_new (const char *desc, gint min, gint max)
         desc++;
     }
 
+    r->idx = idx;
     r->max = max;
     r->min = min;
     return r;
@@ -933,10 +936,18 @@ cind_response_get_desc (CindResponse *r)
     return r->desc;
 }
 
+gint
+cind_response_get_index (CindResponse *r)
+{
+    g_return_val_if_fail (r != NULL, -1);
+
+    return r->idx;
+}
+
 gint
 cind_response_get_min (CindResponse *r)
 {
-    g_return_val_if_fail (r != NULL, 0);
+    g_return_val_if_fail (r != NULL, -1);
 
     return r->min;
 }
@@ -944,7 +955,7 @@ cind_response_get_min (CindResponse *r)
 gint
 cind_response_get_max (CindResponse *r)
 {
-    g_return_val_if_fail (r != NULL, 0);
+    g_return_val_if_fail (r != NULL, -1);
 
     return r->max;
 }
@@ -957,6 +968,7 @@ mm_parse_cind_response (const char *reply, GError **error)
     GHashTable *hash;
     GRegex *r;
     GMatchInfo *match_info;
+    gint idx = 0;
 
     g_return_val_if_fail (reply != NULL, NULL);
 
@@ -992,7 +1004,7 @@ mm_parse_cind_response (const char *reply, GError **error)
             max = atoi (tmp);
             g_free (tmp);
 
-            resp = cind_response_new (desc, min, max);
+            resp = cind_response_new (desc, idx++, min, max);
             if (resp)
                 g_hash_table_insert (hash, g_strdup (resp->desc), resp);
 

src/mm-modem-helpers.h

@@ -72,6 +72,7 @@ char *mm_create_device_identifier (guint vid,
 typedef struct CindResponse CindResponse;
 GHashTable *mm_parse_cind_response  (const char *reply, GError **error);
 const char *cind_response_get_desc  (CindResponse *r);
+gint        cind_response_get_index (CindResponse *r);
 gint        cind_response_get_min   (CindResponse *r);
 gint        cind_response_get_max   (CindResponse *r);
 

src/tests/test-modem-helpers.c

@@ -1103,13 +1103,13 @@ test_cind_results (const char *desc,
 
     for (i = 0; i < expected_results_len; i++) {
         CindEntry *expected = &expected_results[i];
-        CindEntry *compare;
+        CindResponse *compare;
 
         compare = g_hash_table_lookup (results, expected->desc);
         g_assert (compare);
-
+        g_assert_cmpint (i, ==, cind_response_get_index (compare));
-        g_assert_cmpint (expected->min, ==, compare->min);
+        g_assert_cmpint (expected->min, ==, cind_response_get_min (compare));
-        g_assert_cmpint (expected->max, ==, compare->max);
+        g_assert_cmpint (expected->max, ==, cind_response_get_max (compare));
     }
 
     g_hash_table_destroy (results);