colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mbm: don't pass (null) as string when either user or password is empty

Browse Source 
E.g. instead of:
  (ttyACM1): --> 'AT*EIAAUW=2,1,"(null)","vodafone"<CR>'
  (ttyACM1): <-- '<CR><LF>OK<CR><LF>'

Better pass:
  (ttyACM1): --> 'AT*EIAAUW=2,1,"","vodafone"<CR>'
  (ttyACM1): <-- '<CR><LF>OK<CR><LF>'
This commit is contained in:
Aleksander Morgado
2013-04-05 09:43:38 +02:00
parent 1cb5831af3
commit 30e2a0f4d0
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
plugins/mbm/mm-broadband-bearer-mbm.c
View File

@@ -394,8 +394,8 @@ authenticate (Dial3gppContext *ctx)
command = g_strdup_printf ("AT*EIAAUW=%d,1,\"%s\",\"%s\"", command = g_strdup_printf ("AT*EIAAUW=%d,1,\"%s\",\"%s\"",
ctx->cid, ctx->cid,
encoded_user, encoded_user ? encoded_user : "",
encoded_password); encoded_password ? encoded_password : "");
mm_base_modem_at_command_full (ctx->modem, mm_base_modem_at_command_full (ctx->modem,
ctx->primary, ctx->primary,
@@ -410,6 +410,7 @@ authenticate (Dial3gppContext *ctx)
return; return;
} }
mm_dbg ("Authentication not needed");
activate (ctx); activate (ctx);
} }