colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

broadband-modem-qmi: fix assertion when disabling unsolicited events

Browse Source 
Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/230
This commit is contained in:
Aleksander Morgado
2020-06-24 09:31:30 +02:00
parent c6d213d652
commit 408e9f327e
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/mm-broadband-modem-qmi.c
View File

@@ -4739,17 +4739,17 @@ common_enable_disable_unsolicited_events_signal_strength (GTask *task)
g_autoptr(QmiMessageNasSetEventReportInput) input = NULL; g_autoptr(QmiMessageNasSetEventReportInput) input = NULL;
g_autoptr(GArray) thresholds = NULL; g_autoptr(GArray) thresholds = NULL;
/* The device doesn't really like to have many threshold values, so don't
* grow this array without checking first */
static const gint8 thresholds_data[] = { -80, -40, 0, 40, 80 };
ctx = g_task_get_task_data (task); ctx = g_task_get_task_data (task);
/* Only set thresholds during enable */ /* Only set thresholds during enable, but always create the array anyway,
if (ctx->enable) { * as the TLV setter expects it */
/* The device doesn't really like to have many threshold values, so don't thresholds = g_array_sized_new (FALSE, FALSE, sizeof (gint8), G_N_ELEMENTS (thresholds_data));
* grow this array without checking first */ if (ctx->enable)
static const gint8 thresholds_data[] = { -80, -40, 0, 40, 80 };
thresholds = g_array_sized_new (FALSE, FALSE, sizeof (gint8), G_N_ELEMENTS (thresholds_data));
g_array_append_vals (thresholds, thresholds_data, G_N_ELEMENTS (thresholds_data)); g_array_append_vals (thresholds, thresholds_data, G_N_ELEMENTS (thresholds_data));
}
input = qmi_message_nas_set_event_report_input_new (); input = qmi_message_nas_set_event_report_input_new ();
qmi_message_nas_set_event_report_input_set_signal_strength_indicator ( qmi_message_nas_set_event_report_input_set_signal_strength_indicator (