colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

broadband-modem-qmi: don't depend on other TLVs when processing Signal Info

Browse Source 
When processing the NAS Signal Info message, don't assume that a
previously processed TLV creates the MMSignal object for a given
access technology.
This commit is contained in:
Aleksander Morgado
2022-11-22 11:07:22 +00:00
parent f676420b57
commit 49234bd235
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/mm-broadband-modem-qmi.c
View File

@@ -12053,6 +12053,8 @@ signal_load_values_get_signal_info_ready (QmiClientNas *client,
if (qmi_message_nas_get_signal_info_output_get_wcdma_rscp (output, if (qmi_message_nas_get_signal_info_output_get_wcdma_rscp (output,
&rscp_umts, &rscp_umts,
NULL)) { NULL)) {
if (G_UNLIKELY (!ctx->values_result->umts))
ctx->values_result->umts = mm_signal_new ();
mm_signal_set_rscp (ctx->values_result->umts, (-1.0) * ((gdouble)rscp_umts)); mm_signal_set_rscp (ctx->values_result->umts, (-1.0) * ((gdouble)rscp_umts));
} }
@@ -12083,6 +12085,8 @@ signal_load_values_get_signal_info_ready (QmiClientNas *client,
if (qmi_message_nas_get_signal_info_output_get_5g_signal_strength_extended (output, if (qmi_message_nas_get_signal_info_output_get_5g_signal_strength_extended (output,
&rsrq_5g, &rsrq_5g,
NULL)) { NULL)) {
if (G_UNLIKELY (!ctx->values_result->nr5g))
ctx->values_result->nr5g = mm_signal_new ();
mm_signal_set_rsrq (ctx->values_result->nr5g, (gdouble)rsrq_5g); mm_signal_set_rsrq (ctx->values_result->nr5g, (gdouble)rsrq_5g);
} }