colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cinterion: fix warnings with -Wimplicit-fallthrough

Browse Source 
cinterion/mm-broadband-bearer-cinterion.c: In function ‘dial_3gpp_context_step’:
  cinterion/mm-broadband-bearer-cinterion.c:393:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    393 |         ctx->step++;
        |         ~~~~~~~~~^~
  cinterion/mm-broadband-bearer-cinterion.c:396:5: note: here
    396 |     case DIAL_3GPP_CONTEXT_STEP_AUTH: {
        |     ^~~~
  cinterion/mm-broadband-bearer-cinterion.c:419:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    419 |         ctx->step++;
        |         ~~~~~~~~~^~
  cinterion/mm-broadband-bearer-cinterion.c:422:5: note: here
    422 |     case DIAL_3GPP_CONTEXT_STEP_START_SWWAN: {
        |     ^~~~
  cinterion/mm-broadband-bearer-cinterion.c: In function ‘disconnect_3gpp_context_step’:
  cinterion/mm-broadband-bearer-cinterion.c:613:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    613 |         ctx->step++;
        |         ~~~~~~~~~^~
  cinterion/mm-broadband-bearer-cinterion.c:615:5: note: here
    615 |     case DISCONNECT_3GPP_CONTEXT_STEP_STOP_SWWAN: {
        |     ^~~~
This commit is contained in:
Aleksander Morgado
2020-01-31 07:42:56 +01:00
parent eff4ca989d
commit 497398158f
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/cinterion/mm-broadband-bearer-cinterion.c
View File

@@ -389,9 +389,8 @@ dial_3gpp_context_step (GTask *task)
return; return;
} }
/* Fall down to next step */
ctx->step++; ctx->step++;
} } /* fall through */
case DIAL_3GPP_CONTEXT_STEP_AUTH: { case DIAL_3GPP_CONTEXT_STEP_AUTH: {
gchar *command; gchar *command;
@@ -414,10 +413,9 @@ dial_3gpp_context_step (GTask *task)
return; return;
} }
/* Fall down to next step */
mm_dbg ("cinterion dial step %u/%u: authentication not required", ctx->step, DIAL_3GPP_CONTEXT_STEP_LAST); mm_dbg ("cinterion dial step %u/%u: authentication not required", ctx->step, DIAL_3GPP_CONTEXT_STEP_LAST);
ctx->step++; ctx->step++;
} } /* fall through */
case DIAL_3GPP_CONTEXT_STEP_START_SWWAN: { case DIAL_3GPP_CONTEXT_STEP_START_SWWAN: {
gchar *command; gchar *command;
@@ -612,8 +610,8 @@ disconnect_3gpp_context_step (GTask *task)
switch (ctx->step) { switch (ctx->step) {
case DISCONNECT_3GPP_CONTEXT_STEP_FIRST: case DISCONNECT_3GPP_CONTEXT_STEP_FIRST:
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case DISCONNECT_3GPP_CONTEXT_STEP_STOP_SWWAN: { case DISCONNECT_3GPP_CONTEXT_STEP_STOP_SWWAN: {
gchar *command; gchar *command;