From 4a74ae07bc3ddd7b0334c1c6327ba0ca35ec364b Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Thu, 30 Jan 2020 18:28:44 +0100 Subject: [PATCH] sierra: fix warnings with -Wimplicit-fallthrough MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit sierra/mm-broadband-bearer-sierra.c: In function ‘dial_3gpp_context_step’: sierra/mm-broadband-bearer-sierra.c:304:18: error: this statement may fall through [-Werror=implicit-fallthrough=] 304 | ctx->step++; | ~~~~~~~~~^~ sierra/mm-broadband-bearer-sierra.c:306:5: note: here 306 | case DIAL_3GPP_STEP_PS_ATTACH: | ^~~~ sierra/mm-broadband-bearer-sierra.c:398:18: error: this statement may fall through [-Werror=implicit-fallthrough=] 398 | ctx->step++; | ~~~~~~~~~^~ --- plugins/sierra/mm-broadband-bearer-sierra.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/sierra/mm-broadband-bearer-sierra.c b/plugins/sierra/mm-broadband-bearer-sierra.c index a3fd2bbe..cdfd63ee 100644 --- a/plugins/sierra/mm-broadband-bearer-sierra.c +++ b/plugins/sierra/mm-broadband-bearer-sierra.c @@ -300,8 +300,8 @@ dial_3gpp_context_step (GTask *task) switch (ctx->step) { case DIAL_3GPP_STEP_FIRST: - /* Fall down */ ctx->step++; + /* fall through */ case DIAL_3GPP_STEP_PS_ATTACH: mm_base_modem_at_command_full (ctx->modem, @@ -394,8 +394,8 @@ dial_3gpp_context_step (GTask *task) return; } - /* Fall down */ ctx->step++; + /* fall through */ case DIAL_3GPP_STEP_CONNECT: /* We need a net or AT data port */