colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

base-call: no need to keep a modem reference around

Browse Source 
The mm_base_modem_at_command() async calls keep a modem reference
valid for as long as the operation and its completion handler are run,
so there really is no need for the caller (the call operation) to keep
a reference to the modem object itself.
This commit is contained in:
Aleksander Morgado
2017-07-06 10:59:09 +02:00
parent 2ffcd93ebb
commit 4e5ad5585a
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/mm-base-call.c
View File

@@ -641,7 +641,6 @@ call_start (MMBaseCall *self,
gchar *cmd; gchar *cmd;
task = g_task_new (self, NULL, callback, user_data); task = g_task_new (self, NULL, callback, user_data);
g_task_set_task_data (task, g_object_ref (self->priv->modem), g_object_unref);
cmd = g_strdup_printf ("ATD%s;", mm_gdbus_call_get_number (MM_GDBUS_CALL (self))); cmd = g_strdup_printf ("ATD%s;", mm_gdbus_call_get_number (MM_GDBUS_CALL (self)));
mm_base_modem_at_command (self->priv->modem, mm_base_modem_at_command (self->priv->modem,
@@ -724,7 +723,6 @@ call_accept (MMBaseCall *self,
GTask *task; GTask *task;
task = g_task_new (self, NULL, callback, user_data); task = g_task_new (self, NULL, callback, user_data);
g_task_set_task_data (task, g_object_ref (self->priv->modem), g_object_unref);
mm_base_modem_at_command (self->priv->modem, mm_base_modem_at_command (self->priv->modem,
"ATA", "ATA",
@@ -791,7 +789,6 @@ call_hangup (MMBaseCall *self,
GTask *task; GTask *task;
task = g_task_new (self, NULL, callback, user_data); task = g_task_new (self, NULL, callback, user_data);
g_task_set_task_data (task, g_object_ref (self->priv->modem), g_object_unref);
mm_base_modem_at_command (self->priv->modem, mm_base_modem_at_command (self->priv->modem,
"+CHUP", "+CHUP",
@@ -842,7 +839,6 @@ call_send_dtmf (MMBaseCall *self,
gchar *cmd; gchar *cmd;
task = g_task_new (self, NULL, callback, user_data); task = g_task_new (self, NULL, callback, user_data);
g_task_set_task_data (task, g_object_ref (self->priv->modem), g_object_unref);
cmd = g_strdup_printf ("AT+VTS=%c", dtmf[0]); cmd = g_strdup_printf ("AT+VTS=%c", dtmf[0]);
mm_base_modem_at_command (self->priv->modem, mm_base_modem_at_command (self->priv->modem,
@@ -865,7 +861,6 @@ call_delete (MMBaseCall *self,
GTask *task; GTask *task;
task = g_task_new (self, NULL, callback, user_data); task = g_task_new (self, NULL, callback, user_data);
g_task_set_task_data (task, g_object_ref (self->priv->modem), g_object_unref);
g_task_return_boolean (task, TRUE); g_task_return_boolean (task, TRUE);
g_object_unref (task); g_object_unref (task);
} }