colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bearer-qmi: fix incorrect use of mm_base_bearer_get_status

Browse Source 
This patch fixes a bug in packet_service_status_indication_cb(), which
incorrectly treats the MMBearerStatus enum value returned by
mm_base_bearer_get_status() as a MMBearerConnectionStatus enum value.
MMBearerStatus and MMBearerConnectionStatus can't be used
interchangeably as they have different enum values for the
'disconnected' and 'disconnecting' state.
This commit is contained in:
Ben Chan
2017-01-23 23:07:57 -08:00
committed by Aleksander Morgado
parent 4a80c24169
commit 4e5d8d7e8c
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/mm-bearer-qmi.c
View File

@@ -771,11 +771,11 @@ packet_service_status_indication_cb (QmiClientWds *client,
&connection_status, &connection_status,
NULL, NULL,
NULL)) { NULL)) {
MMBearerConnectionStatus bearer_status = mm_base_bearer_get_status (MM_BASE_BEARER (self)); MMBearerStatus bearer_status = mm_base_bearer_get_status (MM_BASE_BEARER (self));
if (connection_status == QMI_WDS_CONNECTION_STATUS_DISCONNECTED && if (connection_status == QMI_WDS_CONNECTION_STATUS_DISCONNECTED &&
bearer_status != MM_BEARER_CONNECTION_STATUS_DISCONNECTED && bearer_status != MM_BEARER_STATUS_DISCONNECTED &&
bearer_status != MM_BEARER_CONNECTION_STATUS_DISCONNECTING) { bearer_status != MM_BEARER_STATUS_DISCONNECTING) {
QmiWdsCallEndReason cer; QmiWdsCallEndReason cer;
QmiWdsVerboseCallEndReasonType verbose_cer_type; QmiWdsVerboseCallEndReasonType verbose_cer_type;
gint16 verbose_cer_reason; gint16 verbose_cer_reason;