colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make sure the response buffer doesn't grow without bounds.

Browse Source
This commit is contained in:
Tambet Ingo
2008-09-11 16:55:44 +03:00
parent 675964a6b2
commit 567278d19d
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/mm-serial.c
View File

@@ -477,11 +477,15 @@ data_available (GIOChannel *source,
g_string_append_len (priv->response, buf, bytes_read); g_string_append_len (priv->response, buf, bytes_read);
} }
/* Make sure the string doesn't grow too long */
if (priv->response->len > SERIAL_BUF_SIZE) {
g_warning ("%s (%s): response buffer filled before repsonse received",
G_STRFUNC, mm_serial_get_device (self));
g_string_erase (priv->response, 0, (SERIAL_BUF_SIZE / 2));
}
if (parse_response (self, priv->response, &err)) if (parse_response (self, priv->response, &err))
mm_serial_got_response (self, err); mm_serial_got_response (self, err);
/* FIXME: Make sure the string doesn't grow too long */
} while (bytes_read == SERIAL_BUF_SIZE || status == G_IO_STATUS_AGAIN); } while (bytes_read == SERIAL_BUF_SIZE || status == G_IO_STATUS_AGAIN);
return TRUE; return TRUE;