From 5ba6a684af22f9d7c2079cee6e4ae5e3fc158d1c Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Thu, 30 Jan 2020 18:49:28 +0100 Subject: [PATCH] telit: fix warnings with -Wimplicit-fallthrough MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit telit/mm-broadband-modem-telit.c: In function ‘qss_setup_step’: telit/mm-broadband-modem-telit.c:619:22: error: this statement may fall through [-Werror=implicit-fallthrough=] 619 | ctx->step++; | ~~~~~~~~~^~ telit/mm-broadband-modem-telit.c:620:9: note: here 620 | case QSS_SETUP_STEP_QUERY: | ^~~~ telit/mm-broadband-modem-telit.c:653:22: error: this statement may fall through [-Werror=implicit-fallthrough=] 653 | ctx->step++; | ~~~~~~~~~^~ telit/mm-broadband-modem-telit.c:654:9: note: here 654 | case QSS_SETUP_STEP_LAST: | ^~~~ telit/mm-broadband-modem-telit.c: In function ‘load_unlock_retries_step’: telit/mm-broadband-modem-telit.c:906:22: error: this statement may fall through [-Werror=implicit-fallthrough=] 906 | ctx->step++; | ~~~~~~~~~^~ telit/mm-broadband-modem-telit.c:907:9: note: here 907 | case LOAD_UNLOCK_RETRIES_STEP_LOCK: | ^~~~ --- plugins/telit/mm-broadband-modem-telit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/telit/mm-broadband-modem-telit.c b/plugins/telit/mm-broadband-modem-telit.c index 676b69ea..4178e7d6 100644 --- a/plugins/telit/mm-broadband-modem-telit.c +++ b/plugins/telit/mm-broadband-modem-telit.c @@ -615,8 +615,8 @@ qss_setup_step (GTask *task) switch (ctx->step) { case QSS_SETUP_STEP_FIRST: - /* Fall back on next step */ ctx->step++; + /* fall through */ case QSS_SETUP_STEP_QUERY: mm_base_modem_at_command (MM_BASE_MODEM (self), "#QSS?", @@ -649,8 +649,8 @@ qss_setup_step (GTask *task) task); return; } - /* Fall back to next step */ ctx->step++; + /* fall through */ case QSS_SETUP_STEP_LAST: /* If all enabling actions failed (either both, or only primary if * there is no secondary), then we return an error */ @@ -905,8 +905,8 @@ load_unlock_retries_step (GTask *task) ctx = g_task_get_task_data (task); switch (ctx->step) { case LOAD_UNLOCK_RETRIES_STEP_FIRST: - /* Fall back on next step */ ctx->step++; + /* fall through */ case LOAD_UNLOCK_RETRIES_STEP_LOCK: handle_csim_locking (task, TRUE); break;