sms: don't allow more than 255 parts

2012-09-14 13:12:02 +02:00
parent d5e57dd8eb
commit 6284737249
1 changed files with 18 additions and 0 deletions
--- a/src/mm-sms.c
+++ b/src/mm-sms.c
@@ -123,6 +123,24 @@ generate_submit_pdus (MMSms *self,
    g_assert (split_text != NULL || split_data != NULL);
    g_assert (!(split_text != NULL && split_data != NULL));

+    if (n_parts > 255) {
+        if (split_text)
+            g_strfreev (split_text);
+        else if (split_data) {
+            guint i = 0;
+
+            while (split_data[i])
+                g_byte_array_unref (split_data[i++]);
+            g_free (split_data);
+        }
+
+        g_set_error (error,
+                     MM_CORE_ERROR,
+                     MM_CORE_ERROR_TOO_MANY,
+                     "Cannot generate PDUs: Text or Data too long");
+        return FALSE;
+    }
+
    /* Loop text/data chunks */
    i = 0;
    while (1) {