colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iface-modem: don't log error if it's in progress

Browse Source 
If we're loading signal quality or access technology, skip reporting
any error message if the specific error received is 'in-progress'.

Plugins will use this error when they cannot process the response to
the operation, e.g. if it was already consumed by a URC handler.
This commit is contained in:
Aleksander Morgado
2019-09-17 13:28:51 +02:00
parent 1f6f9eec4d
commit 765f26a40e
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/mm-iface-modem.c
View File

@@ -1226,7 +1226,9 @@ access_technologies_check_ready (MMIfaceModem *self,
if (g_error_matches (error, MM_CORE_ERROR, MM_CORE_ERROR_UNSUPPORTED)) { if (g_error_matches (error, MM_CORE_ERROR, MM_CORE_ERROR_UNSUPPORTED)) {
mm_dbg ("Polling to refresh access technologies is unsupported"); mm_dbg ("Polling to refresh access technologies is unsupported");
ctx->access_technology_polling_supported = FALSE; ctx->access_technology_polling_supported = FALSE;
} else }
/* Ignore logging any message if the error is in 'in-progress' */
else if (!g_error_matches (error, MM_CORE_ERROR, MM_CORE_ERROR_IN_PROGRESS))
mm_dbg ("Couldn't refresh access technologies: '%s'", error->message); mm_dbg ("Couldn't refresh access technologies: '%s'", error->message);
g_error_free (error); g_error_free (error);
} }
@@ -1254,7 +1256,9 @@ signal_quality_check_ready (MMIfaceModem *self,
if (g_error_matches (error, MM_CORE_ERROR, MM_CORE_ERROR_UNSUPPORTED)) { if (g_error_matches (error, MM_CORE_ERROR, MM_CORE_ERROR_UNSUPPORTED)) {
mm_dbg ("Polling to refresh signal quality is unsupported"); mm_dbg ("Polling to refresh signal quality is unsupported");
ctx->signal_quality_polling_supported = FALSE; ctx->signal_quality_polling_supported = FALSE;
} else }
/* Ignore logging any message if the error is in 'in-progress' */
else if (!g_error_matches (error, MM_CORE_ERROR, MM_CORE_ERROR_IN_PROGRESS))
mm_dbg ("Couldn't refresh signal quality: '%s'", error->message); mm_dbg ("Couldn't refresh signal quality: '%s'", error->message);
g_error_free (error); g_error_free (error);
} }