colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

port-probe: remove the 3s wait before opening a MBIM port

Browse Source 
The 3s wait before opening a MBIM port is not necessary for handling a
delayed response to the MBIM OPEN messages. mbim_device_open() already
retries the MBIM OPEN message when the MBIM device does not respond.
This commit is contained in:
Ben Chan
2014-04-02 23:34:42 -07:00
committed by Aleksander Morgado
parent 09d92ef333
commit 79b34b77b4
1 changed files with 6 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/mm-port-probe.c
View File

@@ -509,22 +509,6 @@ mbim_port_open_ready (MMPortMbim *mbim_port,
self); self);
} }
static gboolean
mbim_sleep_ready (MMPortProbe *self)
{
PortProbeRunTask *task = self->priv->task;
task->source_id = 0;
/* Create a port and try to open it */
task->mbim_port = mm_port_mbim_new (g_udev_device_get_name (self->priv->port));
mm_port_mbim_open (task->mbim_port,
NULL,
(GAsyncReadyCallback)mbim_port_open_ready,
self);
return FALSE;
}
#endif /* WITH_MBIM */ #endif /* WITH_MBIM */
static void static void
@@ -537,7 +521,12 @@ wdm_probe_mbim (MMPortProbe *self)
g_udev_device_get_subsystem (self->priv->port), g_udev_device_get_subsystem (self->priv->port),
g_udev_device_get_name (self->priv->port)); g_udev_device_get_name (self->priv->port));
task->source_id = g_timeout_add_seconds (3, (GSourceFunc)mbim_sleep_ready, self); /* Create a port and try to open it */
task->mbim_port = mm_port_mbim_new (g_udev_device_get_name (self->priv->port));
mm_port_mbim_open (task->mbim_port,
NULL,
(GAsyncReadyCallback)mbim_port_open_ready,
self);
#else #else
/* If not compiled with MBIM support, just assume we won't have any MBIM port */ /* If not compiled with MBIM support, just assume we won't have any MBIM port */
mm_port_probe_set_result_mbim (self, FALSE); mm_port_probe_set_result_mbim (self, FALSE);