colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iface-modem-simple: fix warnings with -Wimplicit-fallthrough

Browse Source 
mm-iface-modem-simple.c: In function ‘connection_step’:
  mm-iface-modem-simple.c:539:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    539 |         ctx->step++;
        |         ~~~~~~~~~^~
  ...
This commit is contained in:
Aleksander Morgado
2019-12-23 13:36:05 +01:00
parent a4dcf5dd68
commit 8744025545
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/mm-iface-modem-simple.c
View File

@@ -536,8 +536,8 @@ connection_step (ConnectionContext *ctx)
switch (ctx->step) { switch (ctx->step) {
case CONNECTION_STEP_FIRST: case CONNECTION_STEP_FIRST:
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case CONNECTION_STEP_UNLOCK_CHECK: case CONNECTION_STEP_UNLOCK_CHECK:
mm_info ("Simple connect state (%d/%d): Unlock check", mm_info ("Simple connect state (%d/%d): Unlock check",
@@ -590,9 +590,9 @@ connection_step (ConnectionContext *ctx)
} }
/* If not 3GPP and not CDMA, this will possibly be a POTS modem, /* If not 3GPP and not CDMA, this will possibly be a POTS modem,
* which won't require any specific registration anywhere. * which won't require any specific registration anywhere. */
* So, fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case CONNECTION_STEP_BEARER: { case CONNECTION_STEP_BEARER: {
MMBearerList *list = NULL; MMBearerList *list = NULL;
@@ -675,9 +675,8 @@ connection_step (ConnectionContext *ctx)
mm_base_bearer_get_path (ctx->bearer)); mm_base_bearer_get_path (ctx->bearer));
g_object_unref (list); g_object_unref (list);
g_object_unref (bearer_properties); g_object_unref (bearer_properties);
/* Fall down to next step */
ctx->step++; ctx->step++;
} } /* fall through */
case CONNECTION_STEP_CONNECT: case CONNECTION_STEP_CONNECT:
mm_info ("Simple connect state (%d/%d): Connect", mm_info ("Simple connect state (%d/%d): Connect",
@@ -699,8 +698,8 @@ connection_step (ConnectionContext *ctx)
mm_dbg ("Bearer at '%s' is already connected...", mm_dbg ("Bearer at '%s' is already connected...",
mm_base_bearer_get_path (ctx->bearer)); mm_base_bearer_get_path (ctx->bearer));
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case CONNECTION_STEP_LAST: case CONNECTION_STEP_LAST:
mm_info ("Simple connect state (%d/%d): All done", mm_info ("Simple connect state (%d/%d): All done",