colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iface-modem-location: fix warnings with -Wimplicit-fallthrough

Browse Source 
mm-iface-modem-location.c: In function ‘interface_disabling_step’:
  mm-iface-modem-location.c:1389:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
   1389 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-iface-modem-location.c:1391:5: note: here
   1391 |     case DISABLING_STEP_DISABLE_GATHERING:
        |     ^~~~
  ...
This commit is contained in:
Aleksander Morgado
2019-12-23 13:40:30 +01:00
parent 3ab3968e8f
commit 8798ea889d
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/mm-iface-modem-location.c
View File

@@ -1406,8 +1406,8 @@ interface_disabling_step (GTask *task)
switch (ctx->step) { switch (ctx->step) {
case DISABLING_STEP_FIRST: case DISABLING_STEP_FIRST:
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case DISABLING_STEP_DISABLE_GATHERING: case DISABLING_STEP_DISABLE_GATHERING:
setup_gathering (self, setup_gathering (self,
@@ -1528,8 +1528,8 @@ interface_enabling_step (GTask *task)
switch (ctx->step) { switch (ctx->step) {
case ENABLING_STEP_FIRST: case ENABLING_STEP_FIRST:
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case ENABLING_STEP_ENABLE_GATHERING: { case ENABLING_STEP_ENABLE_GATHERING: {
MMModemLocationSource default_sources; MMModemLocationSource default_sources;
@@ -1735,8 +1735,8 @@ interface_initialization_step (GTask *task)
switch (ctx->step) { switch (ctx->step) {
case INITIALIZATION_STEP_FIRST: case INITIALIZATION_STEP_FIRST:
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case INITIALIZATION_STEP_CAPABILITIES: case INITIALIZATION_STEP_CAPABILITIES:
/* Location capabilities value is meant to be loaded only once during /* Location capabilities value is meant to be loaded only once during
@@ -1751,8 +1751,8 @@ interface_initialization_step (GTask *task)
task); task);
return; return;
} }
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case INITIALIZATION_STEP_VALIDATE_CAPABILITIES: case INITIALIZATION_STEP_VALIDATE_CAPABILITIES:
/* If the modem doesn't support any location capabilities, we won't export /* If the modem doesn't support any location capabilities, we won't export
@@ -1765,8 +1765,8 @@ interface_initialization_step (GTask *task)
g_object_unref (task); g_object_unref (task);
return; return;
} }
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case INITIALIZATION_STEP_SUPL_SERVER: case INITIALIZATION_STEP_SUPL_SERVER:
/* If the modem supports A-GPS, load SUPL server */ /* If the modem supports A-GPS, load SUPL server */
@@ -1780,8 +1780,8 @@ interface_initialization_step (GTask *task)
task); task);
return; return;
} }
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case INITIALIZATION_STEP_SUPPORTED_ASSISTANCE_DATA: case INITIALIZATION_STEP_SUPPORTED_ASSISTANCE_DATA:
/* If the modem supports any GPS-related technology, check assistance data types supported */ /* If the modem supports any GPS-related technology, check assistance data types supported */
@@ -1797,8 +1797,8 @@ interface_initialization_step (GTask *task)
task); task);
return; return;
} }
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case INITIALIZATION_STEP_ASSISTANCE_DATA_SERVERS: case INITIALIZATION_STEP_ASSISTANCE_DATA_SERVERS:
/* If any assistance data supported, load servers */ /* If any assistance data supported, load servers */
@@ -1811,8 +1811,8 @@ interface_initialization_step (GTask *task)
task); task);
return; return;
} }
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case INITIALIZATION_STEP_GPS_REFRESH_RATE: case INITIALIZATION_STEP_GPS_REFRESH_RATE:
/* If we have GPS capabilities, expose the GPS refresh rate */ /* If we have GPS capabilities, expose the GPS refresh rate */
@@ -1821,8 +1821,8 @@ interface_initialization_step (GTask *task)
/* Set the default rate in the interface */ /* Set the default rate in the interface */
mm_gdbus_modem_location_set_gps_refresh_rate (ctx->skeleton, MM_LOCATION_GPS_REFRESH_TIME_SECS); mm_gdbus_modem_location_set_gps_refresh_rate (ctx->skeleton, MM_LOCATION_GPS_REFRESH_TIME_SECS);
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case INITIALIZATION_STEP_LAST: case INITIALIZATION_STEP_LAST:
/* We are done without errors! */ /* We are done without errors! */