colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iface-modem-time: fix warnings with -Wimplicit-fallthrough

Browse Source 
mm-iface-modem-time.c: In function ‘interface_disabling_step’:
  mm-iface-modem-time.c:484:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    484 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-iface-modem-time.c:486:5: note: here
    486 |     case DISABLING_STEP_CANCEL_NETWORK_TIMEZONE_UPDATE:
        |     ^~~~
  ...
This commit is contained in:
Aleksander Morgado
2019-12-23 13:59:29 +01:00
parent ecce8cb9fc
commit a65fa9e142
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/mm-iface-modem-time.c
View File

@@ -480,14 +480,14 @@ interface_disabling_step (GTask *task)
switch (ctx->step) { switch (ctx->step) {
case DISABLING_STEP_FIRST: case DISABLING_STEP_FIRST:
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case DISABLING_STEP_CANCEL_NETWORK_TIMEZONE_UPDATE: case DISABLING_STEP_CANCEL_NETWORK_TIMEZONE_UPDATE:
/* Stop and cleanup context */ /* Stop and cleanup context */
stop_network_timezone (self); stop_network_timezone (self);
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case DISABLING_STEP_DISABLE_UNSOLICITED_EVENTS: case DISABLING_STEP_DISABLE_UNSOLICITED_EVENTS:
/* Allow cleaning up unsolicited events */ /* Allow cleaning up unsolicited events */
@@ -499,8 +499,8 @@ interface_disabling_step (GTask *task)
task); task);
return; return;
} }
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case DISABLING_STEP_CLEANUP_UNSOLICITED_EVENTS: case DISABLING_STEP_CLEANUP_UNSOLICITED_EVENTS:
/* Allow cleaning up unsolicited events */ /* Allow cleaning up unsolicited events */
@@ -512,8 +512,8 @@ interface_disabling_step (GTask *task)
task); task);
return; return;
} }
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case DISABLING_STEP_LAST: case DISABLING_STEP_LAST:
/* We are done without errors! */ /* We are done without errors! */
@@ -649,14 +649,14 @@ interface_enabling_step (GTask *task)
switch (ctx->step) { switch (ctx->step) {
case ENABLING_STEP_FIRST: case ENABLING_STEP_FIRST:
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case ENABLING_STEP_SETUP_NETWORK_TIMEZONE_RETRIEVAL: case ENABLING_STEP_SETUP_NETWORK_TIMEZONE_RETRIEVAL:
/* We start it and schedule it to run asynchronously */ /* We start it and schedule it to run asynchronously */
start_network_timezone (self); start_network_timezone (self);
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case ENABLING_STEP_SETUP_UNSOLICITED_EVENTS: case ENABLING_STEP_SETUP_UNSOLICITED_EVENTS:
/* Allow setting up unsolicited events */ /* Allow setting up unsolicited events */
@@ -668,8 +668,8 @@ interface_enabling_step (GTask *task)
task); task);
return; return;
} }
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case ENABLING_STEP_ENABLE_UNSOLICITED_EVENTS: case ENABLING_STEP_ENABLE_UNSOLICITED_EVENTS:
/* Allow setting up unsolicited events */ /* Allow setting up unsolicited events */
@@ -681,8 +681,8 @@ interface_enabling_step (GTask *task)
task); task);
return; return;
} }
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case ENABLING_STEP_LAST: case ENABLING_STEP_LAST:
/* We are done without errors! */ /* We are done without errors! */
@@ -805,8 +805,8 @@ interface_initialization_step (GTask *task)
supported_quark = (g_quark_from_static_string ( supported_quark = (g_quark_from_static_string (
SUPPORTED_TAG)); SUPPORTED_TAG));
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case INITIALIZATION_STEP_CHECK_SUPPORT: case INITIALIZATION_STEP_CHECK_SUPPORT:
if (!GPOINTER_TO_UINT (g_object_get_qdata (G_OBJECT (self), if (!GPOINTER_TO_UINT (g_object_get_qdata (G_OBJECT (self),
@@ -832,8 +832,8 @@ interface_initialization_step (GTask *task)
/* If there is no implementation to check support, assume we DON'T /* If there is no implementation to check support, assume we DON'T
* support it. */ * support it. */
} }
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case INITIALIZATION_STEP_FAIL_IF_UNSUPPORTED: case INITIALIZATION_STEP_FAIL_IF_UNSUPPORTED:
if (!GPOINTER_TO_UINT (g_object_get_qdata (G_OBJECT (self), if (!GPOINTER_TO_UINT (g_object_get_qdata (G_OBJECT (self),
@@ -845,8 +845,8 @@ interface_initialization_step (GTask *task)
g_object_unref (task); g_object_unref (task);
return; return;
} }
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case INITIALIZATION_STEP_LAST: case INITIALIZATION_STEP_LAST:
/* We are done without errors! */ /* We are done without errors! */