colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

plugins: always set a proper error domain in GErrors

Browse Source
This commit is contained in:
Aleksander Morgado
2012-02-07 17:05:26 +01:00
parent 23a6156059
commit a8ca3df9be
4 changed files with 31 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/mm-plugin-generic.c
View File

@@ -26,6 +26,8 @@
#include <gmodule.h>
#include <mm-errors-types.h>
#include "mm-plugin-generic.h"
#include "mm-broadband-modem.h"
#include "mm-serial-parsers.h"
@@ -55,7 +57,10 @@ grab_port (MMPluginBase *base,
/* The generic plugin cannot do anything with non-AT and non-QCDM ports */
if (!mm_port_probe_is_at (probe) &&
!mm_port_probe_is_qcdm (probe)) {
g_set_error (error, 0, 0, "Ignoring non-AT/non-QCDM ports");
g_set_error (error,
MM_CORE_ERROR,
MM_CORE_ERROR_UNSUPPORTED,
"Ignoring non-AT/non-QCDM ports");
return NULL;
}
@@ -66,7 +71,10 @@ grab_port (MMPluginBase *base,
devfile = g_udev_device_get_device_file (port);
if (!devfile) {
if (!driver || !g_str_equal (driver, "bluetooth")) {
g_set_error (error, 0, 0, "Could not get port's sysfs file.");
g_set_error (error,
MM_CORE_ERROR,
MM_CORE_ERROR_FAILED,
"Could not get port's sysfs file.");
return NULL;
}