colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iface-modem-messaging: improve logging of user operations

Browse Source
This commit is contained in:
Aleksander Morgado
2022-11-30 13:22:07 +00:00
parent a962d63179
commit c359a05219
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/mm-iface-modem-messaging.c
View File

@@ -166,10 +166,13 @@ handle_delete_ready (MMSmsList *list,
{
GError *error = NULL;
if (!mm_sms_list_delete_sms_finish (list, res, &error))
if (!mm_sms_list_delete_sms_finish (list, res, &error)) {
mm_obj_warn (ctx->self, "failed deleting SMS message '%s': %s", ctx->path, error->message);
g_dbus_method_invocation_take_error (ctx->invocation, error);
else
} else {
mm_obj_info (ctx->self, "deleted SMS message '%s'", ctx->path);
mm_gdbus_modem_messaging_complete_delete (ctx->skeleton, ctx->invocation);
}
handle_delete_context_free (ctx);
}
@@ -211,6 +214,7 @@ handle_delete_auth_ready (MMBaseModem *self,
return;
}
mm_obj_info (self, "processing user request to delete SMS message '%s'...", ctx->path);
mm_sms_list_delete_sms (list,
ctx->path,
(GAsyncReadyCallback)handle_delete_ready,
@@ -308,13 +312,12 @@ handle_create_auth_ready (MMBaseModem *self,
return;
}
/* Add it to the list */
mm_obj_info (self, "processing user request to create SMS message...");
mm_sms_list_add_sms (list, sms);
/* Complete the DBus call */
mm_gdbus_modem_messaging_complete_create (ctx->skeleton,
ctx->invocation,
mm_base_sms_get_path (sms));
mm_obj_info (self, "created SMS message: %s", mm_base_sms_get_path (sms));
handle_create_context_free (ctx);
}
@@ -366,10 +369,12 @@ handle_list (MmGdbusModemMessaging *skeleton,
return TRUE;
}
mm_obj_info (self, "processing user request to list SMS messages...");
paths = mm_sms_list_get_paths (list);
mm_gdbus_modem_messaging_complete_list (skeleton,
invocation,
(const gchar *const *)paths);
mm_obj_info (self, "reported %u SMS messages available", paths ? g_strv_length (paths) : 0);
return TRUE;
}