colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libmm-glib,firmware-update-settings: handle null self pointer

Browse Source 
mm_firmware_update_settings_get_variant() checks for a null `self'
pointer when accessing `self->priv->method', but doesn't perform the
null check when accessing other members of
MMFirmwareUpdateSettingsPrivate.

This patch fixes mm_firmware_update_settings_get_variant() to fully
handle a null `self' pointer.
This commit is contained in:
Ben Chan
2019-08-03 09:12:57 -07:00
parent ee63bf4033
commit c6cf7cf094
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libmm-glib/mm-firmware-update-settings.c
View File

@@ -174,7 +174,7 @@ mm_firmware_update_settings_get_variant (MMFirmwareUpdateSettings *self)
g_variant_builder_add (&builder, "u", method); g_variant_builder_add (&builder, "u", method);
g_variant_builder_open (&builder, G_VARIANT_TYPE ("a{sv}")); g_variant_builder_open (&builder, G_VARIANT_TYPE ("a{sv}"));
{ if (self) {
g_variant_builder_add (&builder, g_variant_builder_add (&builder,
"{sv}", "{sv}",
PROPERTY_DEVICE_IDS, PROPERTY_DEVICE_IDS,