colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

broadband-modem-mbim: fix warnings with -Wtype-limits

Browse Source 
mm-broadband-modem-mbim.c: In function ‘basic_connect_notification_signal_state’:
  /usr/include/glib-2.0/glib/gmacros.h:811:63: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
    811 | ine CLAMP(x, low, high)  (((x) > (high)) ? (high) : (((x) < (low)) ? (low) : (x)))
        |                                                           ^

  mm-broadband-modem-mbim.c:2918:19: note: in expansion of macro ‘CLAMP’
   2918 |         quality = CLAMP (rssi == 99 ? 0 : rssi, 0, 31) * 100 / 31;
        |                   ^~~~~
This commit is contained in:
Aleksander Morgado
2020-01-11 13:23:24 +01:00
parent ac70712f1f
commit c8e4c2e751
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/mm-broadband-modem-mbim.c
View File

@@ -2920,7 +2920,7 @@ basic_connect_notification_signal_state (MMBroadbandModemMbim *self,
guint32 quality; guint32 quality;
/* Normalize the quality. 99 means unknown, we default it to 0 */ /* Normalize the quality. 99 means unknown, we default it to 0 */
quality = CLAMP (rssi == 99 ? 0 : rssi, 0, 31) * 100 / 31; quality = CLAMP (rssi == 99 ? 0 : (gint)rssi, 0, 31) * 100 / 31;
mm_dbg ("Signal state indication: %u --> %u%%", rssi, quality); mm_dbg ("Signal state indication: %u --> %u%%", rssi, quality);
mm_iface_modem_update_signal_quality (MM_IFACE_MODEM (self), quality); mm_iface_modem_update_signal_quality (MM_IFACE_MODEM (self), quality);