colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

broadband-modem-mbim: plug leaks when using the ATDS service

Browse Source
This commit is contained in:
Aleksander Morgado
2018-10-09 14:13:15 +02:00
parent 1ac79ccdfd
commit c906da415c
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/mm-broadband-modem-mbim.c
View File

@@ -3387,6 +3387,9 @@ atds_location_query_ready (MbimDevice *device,
g_task_return_boolean (task, TRUE); g_task_return_boolean (task, TRUE);
} }
g_object_unref (task); g_object_unref (task);
if (response)
mbim_message_unref (response);
} }
static void static void
@@ -3775,8 +3778,7 @@ atds_signal_query_ready (MbimDevice *device,
!mbim_message_response_get_result (response, MBIM_MESSAGE_TYPE_COMMAND_DONE, &error) || !mbim_message_response_get_result (response, MBIM_MESSAGE_TYPE_COMMAND_DONE, &error) ||
!mbim_message_atds_signal_response_parse (response, &rssi, &error_rate, &rscp, &ecno, &rsrq, &rsrp, &snr, &error)) { !mbim_message_atds_signal_response_parse (response, &rssi, &error_rate, &rscp, &ecno, &rsrq, &rsrp, &snr, &error)) {
g_task_return_error (task, error); g_task_return_error (task, error);
g_object_unref (task); goto out;
return;
} }
result = g_slice_new0 (SignalLoadValuesResult); result = g_slice_new0 (SignalLoadValuesResult);
@@ -3825,14 +3827,17 @@ atds_signal_query_ready (MbimDevice *device,
} }
if (!result->gsm && !result->umts && !result->lte) { if (!result->gsm && !result->umts && !result->lte) {
signal_load_values_result_free (result);
g_task_return_new_error (task, MM_CORE_ERROR, MM_CORE_ERROR_FAILED, g_task_return_new_error (task, MM_CORE_ERROR, MM_CORE_ERROR_FAILED,
"No signal details given"); "No signal details given");
g_object_unref (task); goto out;
signal_load_values_result_free (result);
return;
} }
g_task_return_pointer (task, result, (GDestroyNotify) signal_load_values_result_free); g_task_return_pointer (task, result, (GDestroyNotify) signal_load_values_result_free);
out:
if (response)
mbim_message_unref (response);
g_object_unref (task); g_object_unref (task);
} }