colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make +CMEE optional for CDMA modems.

Browse Source 
It's mandatory by spec, so it really shouldn't be optional. Need to figure
out which CDMA modems have problems with it and implement plugin for them.
This commit is contained in:
Tambet Ingo
2008-11-18 12:35:34 +02:00
parent ca4de81fa3
commit cf2344381c
1 changed files with 26 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/mm-generic-cdma.c
View File

@@ -32,7 +32,7 @@ mm_generic_cdma_new (const char *serial_device, const char *driver)
/*****************************************************************************/
static void
init_done (MMSerial *serial,
enable_error_reporting_done (MMSerial *serial,
GString *response,
GError *error,
gpointer user_data)
@@ -40,15 +40,37 @@ init_done (MMSerial *serial,
MMCallbackInfo *info = (MMCallbackInfo *) user_data;
if (error)
info->error = g_error_copy (error);
g_warning ("Your CDMA modem does not support +CMEE command");
/* Ignore errors, see FIXME in init_done() */
mm_callback_info_schedule (info);
}
static void
init_done (MMSerial *serial,
GString *response,
GError *error,
gpointer user_data)
{
MMCallbackInfo *info = (MMCallbackInfo *) user_data;
if (error) {
info->error = g_error_copy (error);
mm_callback_info_schedule (info);
} else {
/* Try to enable better error reporting. My experience so far indicates
there's some CDMA modems that does not support that.
FIXME: It's mandatory by spec, so it really shouldn't be optional. Figure
out which CDMA modems have problems with it and implement plugin for them.
*/
mm_serial_queue_command (serial, "+CMEE=1", 3, enable_error_reporting_done, user_data);
}
}
static void
flash_done (MMSerial *serial, gpointer user_data)
{
mm_serial_queue_command (serial, "Z E0 V1 X4 &C1 +CMEE=1", 3, init_done, user_data);
mm_serial_queue_command (serial, "Z E0 V1 X4 &C1", 3, init_done, user_data);
}
static void