colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

base-call: don't update state twice

Browse Source 
The mm_gdbus_call_set_() methods update the properties in the same way
as via g_object_set(), no need to do it twice.
This commit is contained in:
Aleksander Morgado
2018-06-14 14:34:05 +02:00
committed by Dan Williams
parent 4409ccffcc
commit cfdd6ffc95
2 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/mm-base-call.c
View File

@@ -551,18 +551,9 @@ mm_base_call_change_state (MMBaseCall *self,
if (old_state == new_state) if (old_state == new_state)
return; return;
g_object_set (self,
"state", new_state,
"state-reason", reason,
NULL);
mm_gdbus_call_set_state (MM_GDBUS_CALL (self), new_state); mm_gdbus_call_set_state (MM_GDBUS_CALL (self), new_state);
mm_gdbus_call_set_state_reason (MM_GDBUS_CALL (self), reason); mm_gdbus_call_set_state_reason (MM_GDBUS_CALL (self), reason);
mm_gdbus_call_emit_state_changed (MM_GDBUS_CALL (self), old_state, new_state, reason);
mm_gdbus_call_emit_state_changed (MM_GDBUS_CALL (self),
old_state,
new_state,
reason);
} }
void void

1
src/mm-iface-modem-voice.c
View File

@@ -99,7 +99,6 @@ mm_iface_modem_voice_update_incoming_call_number (MMIfaceModemVoice *self,
call = mm_call_list_get_new_incoming (list); call = mm_call_list_get_new_incoming (list);
if (call) { if (call) {
g_object_set (call, "number", number, NULL);
mm_gdbus_call_set_number (MM_GDBUS_CALL (call), number); mm_gdbus_call_set_number (MM_GDBUS_CALL (call), number);
/* /*