colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

broadband-modem-qmi: plug memleak when listing SMS messages

Browse Source
This commit is contained in:
Aleksander Morgado
2013-07-18 22:43:55 +02:00
parent 0245b6256a
commit d90a6309fb
1 changed files with 21 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
src/mm-broadband-modem-qmi.c
View File

@@ -6719,16 +6719,7 @@ static void
load_initial_sms_parts_step (LoadInitialSmsPartsContext *ctx) load_initial_sms_parts_step (LoadInitialSmsPartsContext *ctx)
{ {
QmiMessageWmsListMessagesInput *input; QmiMessageWmsListMessagesInput *input;
gint tag_type = -1;
/* Request to list messages in a given storage */
input = qmi_message_wms_list_messages_input_new ();
qmi_message_wms_list_messages_input_set_storage_type (
input,
mm_sms_storage_to_qmi_storage_type (ctx->storage),
NULL);
qmi_message_wms_list_messages_input_set_message_mode (input,
QMI_WMS_MESSAGE_MODE_GSM_WCDMA,
NULL);
switch (ctx->step) { switch (ctx->step) {
case LOAD_INITIAL_SMS_PARTS_STEP_FIRST: case LOAD_INITIAL_SMS_PARTS_STEP_FIRST:
@@ -6741,34 +6732,22 @@ load_initial_sms_parts_step (LoadInitialSmsPartsContext *ctx)
case LOAD_INITIAL_SMS_PARTS_STEP_LIST_MT_READ: case LOAD_INITIAL_SMS_PARTS_STEP_LIST_MT_READ:
mm_dbg ("loading MT-read messages from storage '%s'...", mm_dbg ("loading MT-read messages from storage '%s'...",
mm_sms_storage_get_string (ctx->storage)); mm_sms_storage_get_string (ctx->storage));
qmi_message_wms_list_messages_input_set_message_tag ( tag_type = QMI_WMS_MESSAGE_TAG_TYPE_MT_READ;
input,
QMI_WMS_MESSAGE_TAG_TYPE_MT_READ,
NULL);
break; break;
case LOAD_INITIAL_SMS_PARTS_STEP_LIST_MT_NOT_READ: case LOAD_INITIAL_SMS_PARTS_STEP_LIST_MT_NOT_READ:
mm_dbg ("loading MT-not-read messages from storage '%s'...", mm_dbg ("loading MT-not-read messages from storage '%s'...",
mm_sms_storage_get_string (ctx->storage)); mm_sms_storage_get_string (ctx->storage));
qmi_message_wms_list_messages_input_set_message_tag ( tag_type = QMI_WMS_MESSAGE_TAG_TYPE_MT_NOT_READ;
input,
QMI_WMS_MESSAGE_TAG_TYPE_MT_NOT_READ,
NULL);
break; break;
case LOAD_INITIAL_SMS_PARTS_STEP_LIST_MO_SENT: case LOAD_INITIAL_SMS_PARTS_STEP_LIST_MO_SENT:
mm_dbg ("loading MO-sent messages from storage '%s'...", mm_dbg ("loading MO-sent messages from storage '%s'...",
mm_sms_storage_get_string (ctx->storage)); mm_sms_storage_get_string (ctx->storage));
qmi_message_wms_list_messages_input_set_message_tag ( tag_type = QMI_WMS_MESSAGE_TAG_TYPE_MO_SENT;
input,
QMI_WMS_MESSAGE_TAG_TYPE_MO_SENT,
NULL);
break; break;
case LOAD_INITIAL_SMS_PARTS_STEP_LIST_MO_NOT_SENT: case LOAD_INITIAL_SMS_PARTS_STEP_LIST_MO_NOT_SENT:
mm_dbg ("loading MO-not-sent messages from storage '%s'...", mm_dbg ("loading MO-not-sent messages from storage '%s'...",
mm_sms_storage_get_string (ctx->storage)); mm_sms_storage_get_string (ctx->storage));
qmi_message_wms_list_messages_input_set_message_tag ( tag_type = QMI_WMS_MESSAGE_TAG_TYPE_MO_NOT_SENT;
input,
QMI_WMS_MESSAGE_TAG_TYPE_MO_NOT_SENT,
NULL);
break; break;
case LOAD_INITIAL_SMS_PARTS_STEP_LAST: case LOAD_INITIAL_SMS_PARTS_STEP_LAST:
/* All steps done */ /* All steps done */
@@ -6777,6 +6756,22 @@ load_initial_sms_parts_step (LoadInitialSmsPartsContext *ctx)
return; return;
} }
/* Request to list messages in a given storage */
input = qmi_message_wms_list_messages_input_new ();
qmi_message_wms_list_messages_input_set_storage_type (
input,
mm_sms_storage_to_qmi_storage_type (ctx->storage),
NULL);
qmi_message_wms_list_messages_input_set_message_mode (
input,
QMI_WMS_MESSAGE_MODE_GSM_WCDMA,
NULL);
if (tag_type != -1)
qmi_message_wms_list_messages_input_set_message_tag (
input,
(QmiWmsMessageTagType)tag_type,
NULL);
qmi_client_wms_list_messages (QMI_CLIENT_WMS (ctx->client), qmi_client_wms_list_messages (QMI_CLIENT_WMS (ctx->client),
input, input,
5, 5,