From db8c1b9c12c36ee27ea26386de74dbb7801168b4 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Fri, 31 Jan 2020 09:20:58 +0100 Subject: [PATCH] huawei: fix warnings with -Wimplicit-fallthrough MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit huawei/mm-broadband-bearer-huawei.c: In function ‘connect_3gpp_context_step’: huawei/mm-broadband-bearer-huawei.c:378:18: error: this statement may fall through [-Werror=implicit-fallthrough=] 378 | ctx->step++; | ~~~~~~~~~^~ huawei/mm-broadband-bearer-huawei.c:382:5: note: here 382 | case CONNECT_3GPP_CONTEXT_STEP_NDISDUP: { | ^~~~ huawei/mm-broadband-bearer-huawei.c: In function ‘disconnect_3gpp_context_step’: huawei/mm-broadband-bearer-huawei.c:708:18: error: this statement may fall through [-Werror=implicit-fallthrough=] 708 | ctx->step++; | ~~~~~~~~~^~ huawei/mm-broadband-bearer-huawei.c:711:5: note: here 711 | case DISCONNECT_3GPP_CONTEXT_STEP_NDISDUP: | ^~~~ --- plugins/huawei/mm-broadband-bearer-huawei.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/plugins/huawei/mm-broadband-bearer-huawei.c b/plugins/huawei/mm-broadband-bearer-huawei.c index ed175ce2..a15edc60 100644 --- a/plugins/huawei/mm-broadband-bearer-huawei.c +++ b/plugins/huawei/mm-broadband-bearer-huawei.c @@ -376,8 +376,7 @@ connect_3gpp_context_step (GTask *task) self->priv->connect_pending = task; ctx->step++; - /* Fall down to the next step */ - } + } /* fall through */ case CONNECT_3GPP_CONTEXT_STEP_NDISDUP: { const gchar *apn; @@ -706,7 +705,7 @@ disconnect_3gpp_context_step (GTask *task) } ctx->step++; - /* Fall down to the next step */ + /* fall through */ case DISCONNECT_3GPP_CONTEXT_STEP_NDISDUP: mm_base_modem_at_command_full (ctx->modem,