From dcce64a11675105fd979ee46d01daebda08c40e2 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Thu, 30 Jan 2020 18:14:08 +0100 Subject: [PATCH] huawei: fix warnings with -Wsign-compare MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit huawei/mm-modem-helpers-huawei.c: In function ‘mm_huawei_parse_prefmode_response’: huawei/mm-modem-helpers-huawei.c:550:18: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘const unsigned int’} [-Werror=sign-compare] 550 | if (mode == combination->prefmode) | ^~ --- plugins/huawei/mm-modem-helpers-huawei.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/huawei/mm-modem-helpers-huawei.c b/plugins/huawei/mm-modem-helpers-huawei.c index 70de4f54..1715b74c 100644 --- a/plugins/huawei/mm-modem-helpers-huawei.c +++ b/plugins/huawei/mm-modem-helpers-huawei.c @@ -521,7 +521,7 @@ mm_huawei_parse_prefmode_response (const gchar *response, const GArray *supported_mode_combinations, GError **error) { - gint mode; + guint mode; guint i; /* Format: @@ -530,7 +530,7 @@ mm_huawei_parse_prefmode_response (const gchar *response, */ response = mm_strip_tag (response, "^PREFMODE:"); - if (!sscanf (response, "%d", &mode)) { + if (!mm_get_uint_from_str (response, &mode)) { /* Dump error to upper layer */ g_set_error (error, MM_CORE_ERROR,