colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

plugins,telit: remove unnecessary after sim unlock 1s delay

Browse Source 
Currently the Telit modem implements modem_after_sim_unlock() with 1s
timeout, however the #QSS URC management (introduced later) waits for
QSS=1 URC in csim_unlock_periodic_check up to 3s, which makes this 1s
delay not necessary anymore.

see also:
https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/3
This commit is contained in:
Carlo Lobrano
2022-04-07 10:29:33 +02:00
parent 7960b365d5
commit e175ada2ce
1 changed files with 0 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
plugins/telit/mm-broadband-modem-telit.c
View File

@@ -403,39 +403,6 @@ location_load_capabilities (MMIfaceModemLocation *self,
g_task_new (self, NULL, callback, user_data)); g_task_new (self, NULL, callback, user_data));
} }
/*****************************************************************************/
/* After Sim Unlock (Modem interface) */
static gboolean
modem_after_sim_unlock_finish (MMIfaceModem *self,
GAsyncResult *res,
GError **error)
{
return g_task_propagate_boolean (G_TASK (res), error);
}
static gboolean
after_sim_unlock_ready (GTask *task)
{
g_task_return_boolean (task, TRUE);
g_object_unref (task);
return G_SOURCE_REMOVE;
}
static void
modem_after_sim_unlock (MMIfaceModem *self,
GAsyncReadyCallback callback,
gpointer user_data)
{
GTask *task;
task = g_task_new (self, NULL, callback, user_data);
/* A short delay is necessary with some SIMs when
they have just been unlocked. Using 1 second as secure margin. */
g_timeout_add_seconds (1, (GSourceFunc) after_sim_unlock_ready, task);
}
/*****************************************************************************/ /*****************************************************************************/
/* Setup SIM hot swap (Modem interface) */ /* Setup SIM hot swap (Modem interface) */
@@ -1440,8 +1407,6 @@ iface_modem_init (MMIfaceModem *iface)
iface->load_current_modes_finish = mm_shared_telit_load_current_modes_finish; iface->load_current_modes_finish = mm_shared_telit_load_current_modes_finish;
iface->set_current_modes = mm_shared_telit_set_current_modes; iface->set_current_modes = mm_shared_telit_set_current_modes;
iface->set_current_modes_finish = mm_shared_telit_set_current_modes_finish; iface->set_current_modes_finish = mm_shared_telit_set_current_modes_finish;
iface->modem_after_sim_unlock = modem_after_sim_unlock;
iface->modem_after_sim_unlock_finish = modem_after_sim_unlock_finish;
iface->setup_sim_hot_swap = modem_setup_sim_hot_swap; iface->setup_sim_hot_swap = modem_setup_sim_hot_swap;
iface->setup_sim_hot_swap_finish = modem_setup_sim_hot_swap_finish; iface->setup_sim_hot_swap_finish = modem_setup_sim_hot_swap_finish;
} }