colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iface-modem-voice: fix warnings with -Wimplicit-fallthrough

Browse Source 
mm-iface-modem-voice.c: In function ‘interface_disabling_step’:
  mm-iface-modem-voice.c:2589:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
   2589 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-iface-modem-voice.c:2591:5: note: here
   2591 |     case DISABLING_STEP_DISABLE_UNSOLICITED_EVENTS:
        |     ^~~~
  ...
This commit is contained in:
Aleksander Morgado
2019-12-23 13:56:28 +01:00
parent b1d4c9063c
commit e8c64445cc
1 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/mm-iface-modem-voice.c
View File

@@ -2596,8 +2596,8 @@ interface_disabling_step (GTask *task)
switch (ctx->step) { switch (ctx->step) {
case DISABLING_STEP_FIRST: case DISABLING_STEP_FIRST:
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case DISABLING_STEP_DISABLE_UNSOLICITED_EVENTS: case DISABLING_STEP_DISABLE_UNSOLICITED_EVENTS:
/* Allow cleaning up unsolicited events */ /* Allow cleaning up unsolicited events */
@@ -2609,8 +2609,8 @@ interface_disabling_step (GTask *task)
task); task);
return; return;
} }
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case DISABLING_STEP_CLEANUP_UNSOLICITED_EVENTS: case DISABLING_STEP_CLEANUP_UNSOLICITED_EVENTS:
/* Allow cleaning up unsolicited events */ /* Allow cleaning up unsolicited events */
@@ -2622,8 +2622,8 @@ interface_disabling_step (GTask *task)
task); task);
return; return;
} }
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case DISABLING_STEP_LAST: case DISABLING_STEP_LAST:
/* We are done without errors! */ /* We are done without errors! */
@@ -2759,8 +2759,8 @@ interface_enabling_step (GTask *task)
switch (ctx->step) { switch (ctx->step) {
case ENABLING_STEP_FIRST: case ENABLING_STEP_FIRST:
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case ENABLING_STEP_SETUP_UNSOLICITED_EVENTS: case ENABLING_STEP_SETUP_UNSOLICITED_EVENTS:
/* Allow setting up unsolicited events to get notified of incoming calls */ /* Allow setting up unsolicited events to get notified of incoming calls */
@@ -2772,8 +2772,8 @@ interface_enabling_step (GTask *task)
task); task);
return; return;
} }
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case ENABLING_STEP_ENABLE_UNSOLICITED_EVENTS: case ENABLING_STEP_ENABLE_UNSOLICITED_EVENTS:
/* Allow setting up unsolicited events to get notified of incoming calls */ /* Allow setting up unsolicited events to get notified of incoming calls */
@@ -2785,8 +2785,8 @@ interface_enabling_step (GTask *task)
task); task);
return; return;
} }
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case ENABLING_STEP_LAST: case ENABLING_STEP_LAST:
/* We are done without errors! */ /* We are done without errors! */
@@ -2896,8 +2896,8 @@ interface_initialization_step (GTask *task)
switch (ctx->step) { switch (ctx->step) {
case INITIALIZATION_STEP_FIRST: case INITIALIZATION_STEP_FIRST:
/* Fall down to next step */
ctx->step++; ctx->step++;
/* fall through */
case INITIALIZATION_STEP_CHECK_SUPPORT: case INITIALIZATION_STEP_CHECK_SUPPORT:
/* Always check voice support when we run initialization, because /* Always check voice support when we run initialization, because
@@ -2970,9 +2970,8 @@ interface_initialization_step (GTask *task)
} }
g_object_unref (list); g_object_unref (list);
/* Fall down to next step */
ctx->step++; ctx->step++;
} } /* fall through */
case INITIALIZATION_STEP_LAST: case INITIALIZATION_STEP_LAST:
/* Setup all method handlers */ /* Setup all method handlers */