From f2af208f05cbf56f8a44478615d70b7da46c3e42 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Wed, 28 Dec 2011 09:47:41 +0100 Subject: [PATCH] iridium: don't try to update signal quality if not registered Seems that launching AT+CSQF when not registered ends up timing out. AT+CSQF is meant to be the fast version to get the signal quality, and is expected to return instantly with the last cached signal quality value. But if we never got registered, there is no such cached value, so it probably waits to get the first one. --- plugins/mm-modem-iridium-gsm.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/plugins/mm-modem-iridium-gsm.c b/plugins/mm-modem-iridium-gsm.c index a5c2b0d0..9aa4106c 100644 --- a/plugins/mm-modem-iridium-gsm.c +++ b/plugins/mm-modem-iridium-gsm.c @@ -383,6 +383,16 @@ get_signal_quality (MMModemGsmNetwork *modem, info = mm_callback_info_uint_new (MM_MODEM (modem), callback, user_data); + /* If modem is not registered, don't even bother trying to get signal + * quality */ + if (mm_modem_get_state (MM_MODEM (modem)) < MM_MODEM_STATE_REGISTERED) { + mm_dbg ("Not getting signal quality, not registered yet"); + mm_generic_gsm_update_signal_quality (MM_GENERIC_GSM (info->modem), 0); + mm_callback_info_set_result (info, GUINT_TO_POINTER (0), NULL); + mm_callback_info_schedule (info); + return; + } + /* The iridium modem may have a huge delay to get signal quality if we pass * AT+CSQ, so we'll default to use AT+CSQF, which is a fast version that * returns right away the last signal quality value retrieved */