colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libmm-glib,firmware-update-settings: skip dictionary if method is NONE

Browse Source 
No need to process the detailed dictionary if no explicit method is
reported as supported. Avoids unnecessary warnings:

  $ mmcli -m 1 --firmware-status
  ** (mmcli:6887): WARNING **: 15:52:54.664: Invalid initial update settings: Missing required 'device-ids' setting
  error: firmware status unsupported
This commit is contained in:
Aleksander Morgado
2019-01-16 15:56:59 +01:00
parent 6dd8876124
commit f49f325715
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libmm-glib/mm-firmware-update-settings.c
View File

@@ -255,7 +255,7 @@ mm_firmware_update_settings_new_from_variant (GVariant *variant,
g_variant_get (variant, "(u@a{sv})", &method, &dictionary); g_variant_get (variant, "(u@a{sv})", &method, &dictionary);
self = mm_firmware_update_settings_new (method); self = mm_firmware_update_settings_new (method);
if (dictionary) { if ((method != MM_MODEM_FIRMWARE_UPDATE_METHOD_NONE) && dictionary) {
GVariantIter iter; GVariantIter iter;
gchar *key; gchar *key;
GVariant *value; GVariant *value;