colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sierra: skip setting GError if not used

Browse Source 
The return status of mm_base_modem_at_command_finish() already
specifies whether an error has happened or not, so skip creating the
GError if we don't care about the actual error details.
This commit is contained in:
Aleksander Morgado
2017-09-18 20:50:45 -07:00
parent 4fbd88395d
commit fd508d7057
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
plugins/sierra/mm-broadband-modem-sierra.c
View File

@@ -1297,16 +1297,13 @@ status_ready (MMIfaceModemCdma *self,
GTask *task) GTask *task)
{ {
DetailedRegistrationStateResults *results; DetailedRegistrationStateResults *results;
GError *error = NULL;
const gchar *response; const gchar *response;
results = g_task_get_task_data (task); results = g_task_get_task_data (task);
response = mm_base_modem_at_command_finish (MM_BASE_MODEM (self), res, &error);
/* If error, leave superclass' reg state alone if AT!STATUS isn't supported. */ /* If error, leave superclass' reg state alone if AT!STATUS isn't supported. */
if (error) response = mm_base_modem_at_command_finish (MM_BASE_MODEM (self), res, NULL);
g_error_free (error); if (response)
else
parse_status (response, parse_status (response,
&(results->detailed_cdma1x_state), &(results->detailed_cdma1x_state),
&(results->detailed_evdo_state), &(results->detailed_evdo_state),