Commit Graph

5790 Commits

Author SHA1 Message Date
Ben Chan
3f273429a5 broadband-bearer: port initable_init_async to use GTask 2017-07-19 07:08:21 -07:00
Ben Chan
6dc2f23d8f broadband-bearer: port disconnect_{3gpp,cdma} to use GTask 2017-07-19 07:08:20 -07:00
Ben Chan
fd34814b36 broadband-bearer: port disconnect to use GTask 2017-07-19 07:08:00 -07:00
Ben Chan
903e228782 broadband-bearer: port connect_{3gpp,cdma} to use GTask 2017-07-19 07:04:40 -07:00
Ben Chan
be2ac3f256 broadband-bearer: port connect to use GTask 2017-07-19 07:04:40 -07:00
Ben Chan
e356137484 broadband-bearer: port dial_3gpp to use GTask 2017-07-19 07:04:40 -07:00
Ben Chan
8af44d3589 broadband-bearer: fix crm_range_ready
crm_range_ready() misses a return statement after it invokes
interface_initialization_step(), which will lead to an invalid access of
the already freed InitAsyncContext.
2017-07-19 13:56:34 +02:00
Aleksander Morgado
4db3ccf2af helpers: +CNUM parser doesn't return any error 2017-07-19 11:21:27 +02:00
Aleksander Morgado
7ff5e30dce broadband-modem: if no own numbers returned, complete task with NULL
Fixes: 738deebfb4

Reported-by: Colin Helliwell <colin.helliwell@ln-systems.com>
2017-07-19 11:18:11 +02:00
Aleksander Morgado
14dbbad1ad broadband-modem: plug memleak in init_current_storages()
==28664== 4 bytes in 1 blocks are definitely lost in loss record 33 of 4,317
    ==28664==    at 0x4C2BE1F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==28664==    by 0x4C2E164: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==28664==    by 0x644E0CF: g_realloc (in /usr/lib/libglib-2.0.so.0.5200.2)
    ==28664==    by 0x6469C06: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
    ==28664==    by 0x6469C61: g_string_sized_new (in /usr/lib/libglib-2.0.so.0.5200.2)
    ==28664==    by 0x4E8514A: mm_common_build_sms_storages_string (mm-common-helpers.c:116)
    ==28664==    by 0x489035: cpms_query_ready (mm-broadband-modem.c:5428)
    ==28664==    by 0x5E8E335: g_simple_async_result_complete (in /usr/lib/libgio-2.0.so.0.5200.2)
    ==28664==    by 0x44EADF: at_command_ready (mm-base-modem-at.c:503)
    ==28664==    by 0x5E8E335: g_simple_async_result_complete (in /usr/lib/libgio-2.0.so.0.5200.2)
    ==28664==    by 0x4D8122: serial_command_ready (mm-port-serial-at.c:392)
    ==28664==    by 0x5E8E335: g_simple_async_result_complete (in /usr/lib/libgio-2.0.so.0.5200.2)
    ==28664==
    ==28664== 4 bytes in 1 blocks are definitely lost in loss record 34 of 4,317
    ==28664==    at 0x4C2BE1F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==28664==    by 0x4C2E164: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==28664==    by 0x644E0CF: g_realloc (in /usr/lib/libglib-2.0.so.0.5200.2)
    ==28664==    by 0x6469C06: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
    ==28664==    by 0x6469C61: g_string_sized_new (in /usr/lib/libglib-2.0.so.0.5200.2)
    ==28664==    by 0x4E8514A: mm_common_build_sms_storages_string (mm-common-helpers.c:116)
    ==28664==    by 0x489067: cpms_query_ready (mm-broadband-modem.c:5430)
    ==28664==    by 0x5E8E335: g_simple_async_result_complete (in /usr/lib/libgio-2.0.so.0.5200.2)
    ==28664==    by 0x44EADF: at_command_ready (mm-base-modem-at.c:503)
    ==28664==    by 0x5E8E335: g_simple_async_result_complete (in /usr/lib/libgio-2.0.so.0.5200.2)
    ==28664==    by 0x4D8122: serial_command_ready (mm-port-serial-at.c:392)
    ==28664==    by 0x5E8E335: g_simple_async_result_complete (in /usr/lib/libgio-2.0.so.0.5200.2)
2017-07-18 11:31:36 +02:00
Aleksander Morgado
bad79cb5e1 port-serial: plug memleak on error processing
==28664== 216 (120 direct, 96 indirect) bytes in 5 blocks are definitely lost in loss record 4,109 of 4,317
    ==28664==    at 0x4C2BEEF: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==28664==    by 0x644E018: g_malloc (in /usr/lib/libglib-2.0.so.0.5200.2)
    ==28664==    by 0x6465B05: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.5200.2)
    ==28664==    by 0x6469C32: g_string_sized_new (in /usr/lib/libglib-2.0.so.0.5200.2)
    ==28664==    by 0x4D7861: parse_response (mm-port-serial-at.c:142)
    ==28664==    by 0x4D3B52: parse_response_buffer (mm-port-serial.c:857)
    ==28664==    by 0x4D40F2: common_input_available (mm-port-serial.c:981)
    ==28664==    by 0x4D41B4: iochannel_input_available (mm-port-serial.c:1004)
    ==28664==    by 0x64488B4: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.5200.2)
    ==28664==    by 0x6448C77: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
    ==28664==    by 0x6448F91: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.5200.2)
    ==28664==    by 0x438035: main (main.c:180)
2017-07-18 11:28:33 +02:00
Aleksander Morgado
fa31b699ec broadband-modem: remove unneeded InitializationStartedContext struct 2017-07-18 10:53:03 +02:00
Ben Chan
6515c81f44 broadband-modem: port modem_3gpp_cleanup_unsolicited_events to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
81d2d572b4 broadband-modem: port modem_3gpp_setup_unsolicited_events to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
0c49fb3e2f broadband-modem: port modem_voice_{setup,cleanup}_unsolicited_events to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
4a2cc7b731 broadband-modem: port modem_messaging_{setup,cleanup}_unsolicited_events to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
c7e47b97e8 broadband-modem: port modem_cdma_get_detailed_registration_state to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
e040ee27a0 broadband-modem: port modem_cdma_get_service_status to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
610a6299e1 broadband-modem: port modem_3gpp_run_registration_checks to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
a93add611f broadband-modem: port modem_3gpp_load_enabled_facility_locks to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
1fe33d34e8 broadband-modem: port modem_3gpp_load_subscription_state to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
c812101a12 broadband-modem: port modem_3gpp_{enable,disable}_unsolicited_registration_events to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
ece9b87a67 broadband-modem: port modem_3gpp_setup_unsolicited_registration_events to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
7ee52bb99a broadband-modem: port modem_3gpp_cleanup_unsolicited_registration_events to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
dad7c8c403 broadband-modem: port modem_3gpp_{enable,disable}_unsolicited_events to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
5ccefe30c3 broadband-modem: port modem_3gpp_ussd_cancel to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
17dff1f669 broadband-modem: port modem_3gpp_ussd_check_support to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
03977eb501 broadband-modem: port modem_3gpp_ussd_{enable,disable}_unsolicited_result_codes to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
249f880c3c broadband-modem: port modem_3gpp_ussd_{setup,cleanup}_unsolicited_result_codes to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
8b5aa2a41c broadband-modem: port cmti_received to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
511a08c33c broadband-modem: port mm_broadband_modem_lock_sms_storages to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
2ec660024d broadband-modem: port modem_messaging_load_initial_sms_parts to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
78c0bbf41d broadband-modem: port modem_messaging_setup_sms_format to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
de6ba7a7aa broadband-modem: port modem_messaging_set_default_storage to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
101c646cf9 broadband-modem: port modem_messaging_load_supported_storages to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
1d72695df9 broadband-modem: port modem_messaging_init_current_storages to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
c29cd5eb4e broadband-modem: port modem_messaging_check_support to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
ed0c91b71b broadband-modem: port modem_messaging_enable_unsolicited_events to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
c270720e94 broadband-modem: port modem_voice_check_support to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
4249792c4e broadband-modem: port modem_setup_charset to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
d638da86bd broadband-modem: port modem_power_up to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
16a14e768f broadband-modem: port modem_load_power_state to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
49366f7f00 broadband-modem: port modem_load_signal_quality to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
4da7cf96ac broadband-modem: port modem_load_supported_ip_families to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
8c9bcd76c2 broadband-modem: port modem_load_supported_modes to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
738deebfb4 broadband-modem: port modem_load_own_numbers to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
a24a99e702 broadband-modem: port modem_load_current_capabilities to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
6abd626a0b broadband-modem: port modem_load_supported_charsets to use GTask 2017-07-18 10:42:17 +02:00
Ben Chan
524ecfb03e broadband-modem: port modem_load_unlock_required to use GTask 2017-07-18 10:42:16 +02:00
Ben Chan
f7db916169 broadband-modem: port modem_create_bearer to use GTask 2017-07-18 10:42:16 +02:00