Commit Graph

7059 Commits

Author SHA1 Message Date
Aleksander Morgado
f5fa268411 modem-helpers-mbim: fix warnings with -Wswitch-enum
mm-modem-helpers-mbim.c: In function ‘mm_mobile_equipment_error_from_mbim_nw_error’:
  mm-modem-helpers-mbim.c:206:5: error: enumeration value ‘MBIM_NW_ERROR_IMEI_NOT_ACCEPTED’ not handled in switch [-Werror=switch-enum]
    206 |     switch (nw_error) {
        |     ^~~~~~
  mm-modem-helpers-mbim.c: In function ‘mm_bearer_ip_family_from_mbim_context_ip_type’:
  mm-modem-helpers-mbim.c:403:5: error: enumeration value ‘MBIM_CONTEXT_IP_TYPE_DEFAULT’ not handled in switch [-Werror=switch-enum]
    403 |     switch (ip_type) {
        |     ^~~~~~
2020-01-31 14:52:49 +01:00
Aleksander Morgado
fa2330cba4 modem-helpers-mbim: fix warnings with -Wswitch-default
mm-modem-helpers-mbim.c: In function ‘mm_modem_lock_from_mbim_pin_type’:
  mm-modem-helpers-mbim.c:49:5: error: switch missing default case [-Werror=switch-default]
     49 |     switch (pin_type) {
        |     ^~~~~~
  mm-modem-helpers-mbim.c: In function ‘mm_sms_state_from_mbim_message_status’:
  mm-modem-helpers-mbim.c:425:5: error: switch missing default case [-Werror=switch-default]
    425 |     switch (status) {
        |     ^~~~~~
2020-01-31 14:52:49 +01:00
Aleksander Morgado
911a763a55 modem-helpers-qmi: fix warnings with -Wlogical-op
mm-modem-helpers-qmi.c: In function ‘mm_modem_capability_from_qmi_capabilities_context’:
  mm-modem-helpers-qmi.c:1455:31: error: logical ‘and’ of equal expressions [-Werror=logical-op]
   1455 |     else if (ctx->nas_tp_mask && (ctx->nas_tp_mask != QMI_NAS_RADIO_TECHNOLOGY_PREFERENCE_AUTO))
        |                               ^~
2020-01-31 14:52:49 +01:00
Aleksander Morgado
9bd54e76fc modem-helpers-qmi: fix warnings with -Wsign-compare
mm-modem-helpers-qmi.c: In function ‘mm_qmi_unique_id_to_firmware_unique_id’:
  mm-modem-helpers-qmi.c:1653:19: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare]
   1653 |     for (i = 0; i < qmi_unique_id->len; i++) {
        |                   ^
  mm-modem-helpers-qmi.c:1679:11: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare]
   1679 |     if (i != qmi_unique_id->len)
        |           ^~
2020-01-31 14:52:49 +01:00
Aleksander Morgado
7c900c51b5 modem-helpers-qmi: fix warnings with -Wswitch-enum
mm-modem-helpers-qmi.c: In function ‘mm_3gpp_facility_to_qmi_uim_facility’:
  mm-modem-helpers-qmi.c:137:5: error: enumeration value ‘MM_MODEM_3GPP_FACILITY_NONE’ not handled in switch [-Werror=switch-enum]
    137 |     switch (mm) {
        |     ^~~~~~
  mm-modem-helpers-qmi.c:137:5: error: enumeration value ‘MM_MODEM_3GPP_FACILITY_SIM’ not handled in switch [-Werror=switch-enum]
  mm-modem-helpers-qmi.c:137:5: error: enumeration value ‘MM_MODEM_3GPP_FACILITY_FIXED_DIALING’ not handled in switch [-Werror=switch-enum]
  mm-modem-helpers-qmi.c:137:5: error: enumeration value ‘MM_MODEM_3GPP_FACILITY_PH_FSIM’ not handled in switch [-Werror=switch-enum]
  ...
2020-01-31 14:52:49 +01:00
Aleksander Morgado
40327b1b48 sms-part-cdma: fix warnings with -Wswitch-default
mm-sms-part-cdma.c: In function ‘mm_sms_part_cdma_new_from_binary_pdu’:
  mm-sms-part-cdma.c:1138:5: error: switch missing default case [-Werror=switch-default]
   1138 |     switch (message_type) {
        |     ^~~~~~
2020-01-31 14:52:49 +01:00
Aleksander Morgado
a5c0a7849a sms-part-3gpp: fix warnings with -Wswitch-enum
mm-sms-part-3gpp.c: In function ‘mm_sms_part_3gpp_new_from_binary_pdu’:
  mm-sms-part-3gpp.c:721:9: error: enumeration value ‘MM_SMS_ENCODING_8BIT’ not handled in switch [-Werror=switch-enum]
    721 |         switch (user_data_encoding) {
        |         ^~~~~~
  mm-sms-part-3gpp.c: In function ‘mm_sms_part_3gpp_get_submit_pdu’:
  mm-sms-part-3gpp.c:917:5: error: enumeration value ‘MM_SMS_ENCODING_UNKNOWN’ not handled in switch [-Werror=switch-enum]
    917 |     switch (mm_sms_part_get_encoding (part)) {
        |     ^~~~~~
  mm-sms-part-3gpp.c:917:5: error: enumeration value ‘MM_SMS_ENCODING_8BIT’ not handled in switch [-Werror=switch-enum]
2020-01-31 14:52:49 +01:00
Aleksander Morgado
6a7b1e7b8c sms-part-3gpp: fix warnings with -Wswitch-enum
mm-sms-part-3gpp.c: In function ‘mm_sms_part_3gpp_new_from_binary_pdu’:
  mm-sms-part-3gpp.c:607:9: error: enumeration value ‘MM_SMS_ENCODING_UNKNOWN’ not handled in switch [-Werror=switch-enum]
    607 |         switch (user_data_encoding) {
        |         ^~~~~~
  mm-sms-part-3gpp.c:714:9: error: enumeration value ‘MM_SMS_ENCODING_UNKNOWN’ not handled in switch [-Werror=switch-enum]
    714 |         switch (user_data_encoding) {
        |         ^~~~~~
2020-01-31 14:52:49 +01:00
Aleksander Morgado
5eedad988e sms-part-3gpp: fix warnings with -Wswitch-default
mm-sms-part-3gpp.c: In function ‘sms_encoding_type’:
  mm-sms-part-3gpp.c:190:13: error: switch missing default case [-Werror=switch-default]
    190 |             switch (dcs & 0x0c) {
        |             ^~~~~~
  mm-sms-part-3gpp.c:219:13: error: switch missing default case [-Werror=switch-default]
    219 |             switch (dcs & 0x04) {
        |             ^~~~~~
2020-01-31 14:52:49 +01:00
Aleksander Morgado
6dfb9d7a7e charsets: fix warnings with -Wswitch-default
mm-charsets.c: In function ‘mm_charset_take_and_convert_to_utf8’:
  mm-charsets.c:730:5: error: switch missing default case [-Werror=switch-default]
    730 |     switch (charset) {
        |     ^~~~~~
  mm-charsets.c: In function ‘mm_utf8_take_and_convert_to_charset’:
  mm-charsets.c:852:5: error: switch missing default case [-Werror=switch-default]
    852 |     switch (charset) {
        |     ^~~~~~
2020-01-31 14:52:49 +01:00
Aleksander Morgado
7619148aa5 charsets: fix warnings with -Wsign-compare
mm-charsets.c: In function ‘mm_charset_gsm_unpacked_to_utf8’:
  mm-charsets.c:423:19: error: comparison of integer expressions of different signedness: ‘int’ and ‘guint32’ {aka ‘unsigned int’} [-Werror=sign-compare]
    423 |     for (i = 0; i < len; i++) {
        |                   ^
  mm-charsets.c: In function ‘pccp437_is_subset’:
  mm-charsets.c:544:19: error: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Werror=sign-compare]
    544 |     for (i = 0; i < G_N_ELEMENTS (t); i++) {
        |                   ^
  mm-charsets.c: In function ‘pcdn_is_subset’:
  mm-charsets.c:575:19: error: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Werror=sign-compare]
    575 |     for (i = 0; i < sizeof (t) / sizeof (t[0]); i++) {
        |                   ^
  mm-charsets.c: In function ‘mm_charset_gsm_unpack’:
  mm-charsets.c:657:19: error: comparison of integer expressions of different signedness: ‘int’ and ‘guint32’ {aka ‘unsigned int’} [-Werror=sign-compare]
    657 |     for (i = 0; i < num_septets; i++) {
        |                   ^
  mm-charsets.c: In function ‘mm_charset_gsm_pack’:
  mm-charsets.c:701:42: error: comparison of integer expressions of different signedness: ‘int’ and ‘guint32’ {aka ‘unsigned int’} [-Werror=sign-compare]
    701 |     for (i = 0, lshift = start_offset; i < src_len; i++) {
        |                                          ^
2020-01-31 14:52:49 +01:00
Aleksander Morgado
623443d50f modem-helpers: fix warnings with -Wswitch-enum
mm-modem-helpers.c: In function ‘mm_3gpp_get_pdp_type_from_ip_family’:
  mm-modem-helpers.c:4166:5: error: enumeration value ‘MM_BEARER_IP_FAMILY_NONE’ not handled in switch [-Werror=switch-enum]
   4166 |     switch (family) {
        |     ^~~~~~
  mm-modem-helpers.c:4166:5: error: enumeration value ‘MM_BEARER_IP_FAMILY_ANY’ not handled in switch [-Werror=switch-enum]
2020-01-31 14:52:49 +01:00
Aleksander Morgado
520a7ec7db modem-helpers: fix warnings with -Wdiscarded-qualifiers
mm-modem-helpers.c:4019:45: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
   4019 |     { MM_MODEM_3GPP_FACILITY_SIM,           "SC" },
        |                                             ^~~~
  mm-modem-helpers.c:4020:45: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
   4020 |     { MM_MODEM_3GPP_FACILITY_PH_SIM,        "PS" },
        |                                             ^~~~
  mm-modem-helpers.c:4021:45: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
   4021 |     { MM_MODEM_3GPP_FACILITY_PH_FSIM,       "PF" },
        |                                             ^~~~
  mm-modem-helpers.c:4022:45: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
   4022 |     { MM_MODEM_3GPP_FACILITY_FIXED_DIALING, "FD" },
        |                                             ^~~~
  mm-modem-helpers.c:4023:45: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
   4023 |     { MM_MODEM_3GPP_FACILITY_NET_PERS,      "PN" },
        |                                             ^~~~
  mm-modem-helpers.c:4024:45: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
   4024 |     { MM_MODEM_3GPP_FACILITY_NET_SUB_PERS,  "PU" },
        |                                             ^~~~
  mm-modem-helpers.c:4025:45: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
   4025 |     { MM_MODEM_3GPP_FACILITY_PROVIDER_PERS, "PP" },
        |                                             ^~~~
  mm-modem-helpers.c:4026:45: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
   4026 |     { MM_MODEM_3GPP_FACILITY_CORP_PERS,     "PC" }
        |                                             ^~~~
2020-01-31 14:52:49 +01:00
Aleksander Morgado
1f94d3f5f8 modem-helpers: fix warnings with -Wsign-compare
mm-modem-helpers.c: In function ‘parse_uint’:
  mm-modem-helpers.c:1953:36: error: comparison of integer expressions of different signedness: ‘gulong’ {aka ‘long unsigned int’} and ‘glong’ {aka ‘long int’} [-Werror=sign-compare]
   1953 |         if ((nmin == nmax) || (ret >= nmin && ret <= nmax))
        |                                    ^~
  mm-modem-helpers.c:1953:51: error: comparison of integer expressions of different signedness: ‘gulong’ {aka ‘long unsigned int’} and ‘glong’ {aka ‘long int’} [-Werror=sign-compare]
   1953 |         if ((nmin == nmax) || (ret >= nmin && ret <= nmax))
        |                                                   ^~
2020-01-31 14:52:49 +01:00
Aleksander Morgado
02e5015b5c port-qmi: fix warnings with -Wimplicit-fallthrough
mm-port-qmi.c:353:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    353 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-port-qmi.c:356:5: note: here
    356 |     case PORT_OPEN_STEP_CHECK_OPENING:
        |     ^~~~
  mm-port-qmi.c:366:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    366 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-port-qmi.c:369:5: note: here
    369 |     case PORT_OPEN_STEP_CHECK_ALREADY_OPEN:
        |     ^~~~
  mm-port-qmi.c:376:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    376 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-port-qmi.c:379:5: note: here
    379 |     case PORT_OPEN_STEP_DEVICE_NEW: {
        |     ^~~~
  mm-port-qmi.c:424:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    424 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-port-qmi.c:427:5: note: here
    427 |     case PORT_OPEN_STEP_ALLOCATE_WDA_CLIENT:
        |     ^~~~
  mm-port-qmi.c:474:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    474 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-port-qmi.c:477:5: note: here
    477 |     case PORT_OPEN_STEP_SET_KERNEL_DATA_FORMAT:
        |     ^~~~
2020-01-31 14:52:49 +01:00
Aleksander Morgado
a4b5419287 port-qmi: fix warnings with -Wswitch-default
mm-port-qmi.c: In function ‘port_open_step’:
  mm-port-qmi.c:350:5: error: switch missing default case [-Werror=switch-default]
    350 |     switch (ctx->step) {
        |     ^~~~~~
2020-01-31 14:52:49 +01:00
Aleksander Morgado
afc314e596 port-serial-qcdm: fix warnings with -Wsign-compare
mm-port-serial-qcdm.c: In function ‘find_qcdm_start’:
  mm-port-serial-qcdm.c:51:19: error: comparison of integer expressions of different signedness: ‘int’ and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare]
     51 |     for (i = 0; i < response->len; i++) {
        |                   ^
2020-01-30 19:09:52 +01:00
Aleksander Morgado
8d3d1183b9 port-serial: fix warnings with -Wimplicit-fallthrough
mm-port-serial.c: In function ‘port_serial_process_command’:
  mm-port-serial.c:605:16: error: this statement may fall through [-Werror=implicit-fallthrough=]
    605 |             if (written > 0) {
        |                ^
  mm-port-serial.c:611:9: note: here
    611 |         case G_IO_STATUS_AGAIN:
        |         ^~~~
2020-01-30 19:09:52 +01:00
Aleksander Morgado
a812e06b96 port-serial: fix warnings with -Wsign-compare
mm-port-serial.c: In function ‘_close_internal’:
  mm-port-serial.c:1464:19: error: comparison of integer expressions of different signedness: ‘int’ and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare]
   1464 |     for (i = 0; i < g_queue_get_length (self->priv->queue); i++) {
        |                   ^
2020-01-30 19:09:52 +01:00
Aleksander Morgado
0c16898c30 port-serial: fix warnings with -Wswitch-default
mm-port-serial.c: In function ‘port_serial_process_command’:
  mm-port-serial.c:594:9: error: switch missing default case [-Werror=switch-default]
    594 |         switch (write_status) {
        |         ^~~~~~
  mm-port-serial.c: In function ‘parse_response_buffer’:
  mm-port-serial.c:925:5: error: switch missing default case [-Werror=switch-default]
    925 |     switch (MM_PORT_SERIAL_GET_CLASS (self)->parse_response (self,
        |     ^~~~~~
2020-01-30 19:09:52 +01:00
Aleksander Morgado
6d54691930 broadband-modem-mbim: fix warnings with -Wshadow
mm-broadband-modem-mbim.c: In function ‘ussd_cancel_ready’:
  mm-broadband-modem-mbim.c:5005:16: error: declaration of ‘task’ shadows a parameter [-Werror=shadow]
   5005 |         GTask *task;
        |                ^~~~
  mm-broadband-modem-mbim.c:4991:34: note: shadowed declaration is here
   4991 |                    GTask        *task)
        |                    ~~~~~~~~~~~~~~^~~~
2020-01-30 19:09:52 +01:00
Aleksander Morgado
bcd380a6f1 broadband-modem-mbim: fix warnings with -Wdouble-promotion
mm-broadband-modem-mbim.c: In function ‘atds_signal_query_ready’:
  mm-broadband-modem-mbim.c:4389:49: error: implicit conversion from ‘float’ to ‘double’ to match other operand of binary expression [-Werror=double-promotion]
   4389 |         mm_signal_set_ecio (result->umts, -24.0 + ((float) ecno / 2));
        |                                                 ^
  mm-broadband-modem-mbim.c:4394:48: error: implicit conversion from ‘float’ to ‘double’ to match other operand of binary expression [-Werror=double-promotion]
   4394 |         mm_signal_set_rsrq (result->lte, -19.5 + ((float) rsrq / 2));
        |                                                ^
2020-01-30 19:09:52 +01:00
Aleksander Morgado
c8e4c2e751 broadband-modem-mbim: fix warnings with -Wtype-limits
mm-broadband-modem-mbim.c: In function ‘basic_connect_notification_signal_state’:
  /usr/include/glib-2.0/glib/gmacros.h:811:63: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
    811 | ine CLAMP(x, low, high)  (((x) > (high)) ? (high) : (((x) < (low)) ? (low) : (x)))
        |                                                           ^

  mm-broadband-modem-mbim.c:2918:19: note: in expansion of macro ‘CLAMP’
   2918 |         quality = CLAMP (rssi == 99 ? 0 : rssi, 0, 31) * 100 / 31;
        |                   ^~~~~
2020-01-30 19:09:52 +01:00
Aleksander Morgado
ac70712f1f broadband-modem-mbim: fix warnings with -Wtype-limits
This change is exclusively to make the compiler happy, don't even like
it myself...

  mm-broadband-modem-mbim.c: In function ‘signal_state_query_ready’:
  /usr/include/glib-2.0/glib/gmacros.h:811:63: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
    811 | #define CLAMP(x, low, high)  (((x) > (high)) ? (high) : (((x) < (low)) ? (low) : (x)))
        |                                                               ^
  mm-broadband-modem-mbim.c:1680:19: note: in expansion of macro ‘CLAMP’
   1680 |         quality = CLAMP (rssi == 99 ? 0 : rssi, 0, 31) * 100 / 31;
        |                   ^~~~~
2020-01-30 19:09:52 +01:00
Aleksander Morgado
7e67cbfe42 broadband-modem-mbim: fix warnings with -Wswitch-enum
mm-broadband-modem-mbim.c: In function ‘query_device_services_ready’:
  mm-broadband-modem-mbim.c:2132:13: error: enumeration value ‘MBIM_SERVICE_INVALID’ not handled in switch [-Werror=switch-enum]
   2132 |             switch (service) {
        |             ^~~~~~
  mm-broadband-modem-mbim.c:2132:13: error: enumeration value ‘MBIM_SERVICE_BASIC_CONNECT’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-mbim.c:2132:13: error: enumeration value ‘MBIM_SERVICE_SMS’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-mbim.c:2132:13: error: enumeration value ‘MBIM_SERVICE_PHONEBOOK’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-mbim.c:2132:13: error: enumeration value ‘MBIM_SERVICE_STK’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-mbim.c:2132:13: error: enumeration value ‘MBIM_SERVICE_AUTH’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-mbim.c:2132:13: error: enumeration value ‘MBIM_SERVICE_DSS’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-mbim.c:2132:13: error: enumeration value ‘MBIM_SERVICE_MS_FIRMWARE_ID’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-mbim.c:2132:13: error: enumeration value ‘MBIM_SERVICE_MS_HOST_SHUTDOWN’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-mbim.c:2132:13: error: enumeration value ‘MBIM_SERVICE_PROXY_CONTROL’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-mbim.c:2132:13: error: enumeration value ‘MBIM_SERVICE_QMI’ not handled in switch [-Werror=switch-enum]
2020-01-30 19:09:52 +01:00
Aleksander Morgado
9cffa62cf6 bearer-mbim: fix warnings with -Wimplicit-fallthrough
mm-bearer-mbim.c: In function ‘connect_context_step’:
  mm-bearer-mbim.c:843:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    843 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-bearer-mbim.c:845:5: note: here
    845 |     case CONNECT_STEP_PACKET_SERVICE: {
        |     ^~~~
  mm-bearer-mbim.c: In function ‘disconnect_context_step’:
  mm-bearer-mbim.c:1269:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
   1269 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-bearer-mbim.c:1271:5: note: here
   1271 |     case DISCONNECT_STEP_DISCONNECT: {
        |     ^~~~
2020-01-30 11:59:15 +01:00
Aleksander Morgado
0a47c4bb6a bearer-mbim: fix warnings with -Wswitch-default
mm-bearer-mbim.c: In function ‘connect_context_step’:
  mm-bearer-mbim.c:840:5: error: switch missing default case [-Werror=switch-default]
    840 |     switch (ctx->step) {
        |     ^~~~~~
  mm-bearer-mbim.c: In function ‘disconnect_context_step’:
  mm-bearer-mbim.c:1266:5: error: switch missing default case [-Werror=switch-default]
   1266 |     switch (ctx->step) {
        |     ^~~~~~
  ...
2020-01-30 11:59:15 +01:00
Aleksander Morgado
d068d0493e broadband-modem-qmi: fix warnings with -Wimplicit-fallthrough
In file included from mm-broadband-modem-qmi.c:29:
  mm-broadband-modem-qmi.c: In function ‘uim_get_card_status_output_parse’:
  mm-log.h:33:5: error: this statement may fall through [-Werror=implicit-fallthrough=]
     33 |     _mm_log (G_STRLOC, G_STRFUNC, MM_LOG_LEVEL_WARN, ## __VA_ARGS__ )
        |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  mm-broadband-modem-qmi.c:894:13: note: in expansion of macro ‘mm_warn’
    894 |             mm_warn ("PUK2 permanently blocked");
        |             ^~~~~~~
  mm-broadband-modem-qmi.c:895:9: note: here
    895 |         case QMI_UIM_PIN_STATE_BLOCKED:
        |         ^~~~
  ...
2020-01-30 11:59:15 +01:00
Aleksander Morgado
581d829eb7 broadband-modem-qmi: fix warnings with -Wswitch-enum
mm-broadband-modem-qmi.c: In function ‘qmi_dbm_valid’:
  mm-broadband-modem-qmi.c:1385:5: error: enumeration value ‘QMI_NAS_RADIO_INTERFACE_UNKNOWN’ not handled in switch [-Werror=switch-enum]
   1385 |     switch (radio_interface) {
        |     ^~~~~~
  mm-broadband-modem-qmi.c:1385:5: error: enumeration value ‘QMI_NAS_RADIO_INTERFACE_NONE’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-qmi.c:1385:5: error: enumeration value ‘QMI_NAS_RADIO_INTERFACE_AMPS’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-qmi.c:1385:5: error: enumeration value ‘QMI_NAS_RADIO_INTERFACE_GSM’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-qmi.c:1385:5: error: enumeration value ‘QMI_NAS_RADIO_INTERFACE_LTE’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-qmi.c:1385:5: error: enumeration value ‘QMI_NAS_RADIO_INTERFACE_TD_SCDMA’ not handled in switch [-Werror=switch-enum]
  ...
2020-01-30 11:59:15 +01:00
Aleksander Morgado
92c219480b broadband-modem-qmi: fix warnings with -Wswitch-default
mm-broadband-modem-qmi.c: In function ‘load_unlock_required_context_step’:
  mm-broadband-modem-qmi.c:1062:5: error: switch missing default case [-Werror=switch-default]
   1062 |     switch (ctx->step) {
        |     ^~~~~~
  ...
2020-01-30 11:59:15 +01:00
Aleksander Morgado
8b9cb48916 broadband-modem-qmi: fix warnings with -Wswitch-enum
mm-broadband-modem-qmi.c: In function ‘uim_get_card_status_output_parse’:
  mm-broadband-modem-qmi.c:846:5: error: enumeration value ‘QMI_UIM_PIN_STATE_NOT_INITIALIZED’ not handled in switch [-Werror=switch-enum]
    846 |     switch (app->pin1_state) {
        |     ^~~~~~
  mm-broadband-modem-qmi.c:877:9: error: enumeration value ‘QMI_UIM_PIN_STATE_NOT_INITIALIZED’ not handled in switch [-Werror=switch-enum]
    877 |         switch (app->pin2_state) {
        |         ^~~~~~
  ...
2020-01-30 11:59:14 +01:00
Aleksander Morgado
0db74e1d86 bearer-qmi: fix warnings with -Wimplicit-fallthrough
mm-bearer-qmi.c:168:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    168 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-bearer-qmi.c:169:5: note: here
    169 |     case RELOAD_STATS_CONTEXT_STEP_IPV4:
        |     ^~~~
  ...
2020-01-30 11:59:14 +01:00
Aleksander Morgado
be516b5aa8 bearer-qmi: fix warnings with -Wswitch-default
mm-bearer-qmi.c: In function ‘reload_stats_context_step’:
  mm-bearer-qmi.c:165:5: error: switch missing default case [-Werror=switch-default]
    165 |     switch (ctx->step) {
        |     ^~~~~~
  mm-bearer-qmi.c: In function ‘connection_status_context_step’:
  mm-bearer-qmi.c:310:5: error: switch missing default case [-Werror=switch-default]
    310 |     switch (ctx->step) {
        |     ^~~~~~
  mm-bearer-qmi.c: In function ‘connect_context_step’:
  mm-bearer-qmi.c:1290:5: error: switch missing default case [-Werror=switch-default]
   1290 |     switch (ctx->step) {
        |     ^~~~~~
  mm-bearer-qmi.c: In function ‘disconnect_context_step’:
  mm-bearer-qmi.c:1954:5: error: switch missing default case [-Werror=switch-default]
   1954 |     switch (ctx->step) {
        |     ^~~~~~
2020-01-30 11:59:14 +01:00
Aleksander Morgado
f1126d535b shared-qmi: fix warnings with -Wswitch-enum
mm-shared-qmi.c: In function ‘pds_set_default_tracking_session_ready’:
  mm-shared-qmi.c:4209:5: error: enumeration value ‘GPS_OPERATION_MODE_UNKNOWN’ not handled in switch [-Werror=switch-enum]
   4209 |     switch (ctx->mode) {
        |     ^~~~~~
  mm-shared-qmi.c: In function ‘loc_location_set_operation_mode_indication_cb’:
  mm-shared-qmi.c:4354:5: error: enumeration value ‘GPS_OPERATION_MODE_UNKNOWN’ not handled in switch [-Werror=switch-enum]
   4354 |     switch (ctx->mode) {
        |     ^~~~~~
2020-01-30 11:59:14 +01:00
Aleksander Morgado
8defd21bc4 shared-qmi: fix warnings with -Wsign-compare
mm-shared-qmi.c: In function ‘get_config_info_indication’:
  mm-shared-qmi.c:2843:19: error: comparison of integer expressions of different signedness: ‘int’ and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare]
   2843 |     for (i = 0; i < ctx->config_list->len; i++) {
        |                   ^
  mm-shared-qmi.c:2850:11: error: comparison of integer expressions of different signedness: ‘int’ and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare]
   2850 |     if (i == ctx->config_list->len)
        |           ^~
  mm-shared-qmi.c: In function ‘list_configs_indication’:
  mm-shared-qmi.c:2927:19: error: comparison of integer expressions of different signedness: ‘int’ and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare]
   2927 |     for (i = 0; i < configs->len; i++) {
        |                   ^
2020-01-30 11:59:14 +01:00
Aleksander Morgado
25ea9d9bdd shared-qmi: fix warnings with -Wswitch-default
mm-shared-qmi.c: In function ‘set_current_capabilities_step’:
  mm-shared-qmi.c:601:5: error: switch missing default case [-Werror=switch-default]
    601 |     switch (ctx->step) {
        |     ^~~~~~
  mm-shared-qmi.c: In function ‘load_current_capabilities_step’:
  mm-shared-qmi.c:868:5: error: switch missing default case [-Werror=switch-default]
    868 |     switch (ctx->step) {
        |     ^~~~~~
  mm-shared-qmi.c: In function ‘setup_carrier_config_step’:
  mm-shared-qmi.c:2473:5: error: switch missing default case [-Werror=switch-default]
   2473 |     switch (ctx->step) {
        |     ^~~~~~
2020-01-30 11:59:14 +01:00
Aleksander Morgado
a16ac01604 tests,at-serial-port: fix warnings with -Wdiscarded-qualifiers
test-at-serial-port.c:29:7: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
     29 |     { "\r\n", "\r\n" },
        |       ^~~~~~
  test-at-serial-port.c:29:15: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
     29 |     { "\r\n", "\r\n" },
        |               ^~~~~~
2020-01-30 11:59:14 +01:00
Aleksander Morgado
de3a2f5d2e utils: fix warnings with -Wredundant-decls
In file included from mm-sleep-monitor.c:30:
  mm-utils.h:28:18: error: redundant redeclaration of ‘singleton_instance’ [-Werror=redundant-decls]
e     28 |     static TYPE *singleton_instance
        |                  ^~~~~~~~~~~~~~~~~~
  mm-utils.h:31:5: note: in expansion of macro ‘MM_DEFINE_SINGLETON_INSTANCE’
     31 |     MM_DEFINE_SINGLETON_INSTANCE (TYPE);                                \
        |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  mm-utils.h:65:5: note: in expansion of macro ‘MM_DEFINE_SINGLETON_WEAK_REF’
     65 |     MM_DEFINE_SINGLETON_WEAK_REF (TYPE);                                \
        |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
2020-01-30 11:59:14 +01:00
Aleksander Morgado
a246c36087 plugin: fix warnings with -Wdiscarded-qualifiers
mm-plugin.c:50:33: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
     50 | static gchar *virtual_port[] = {"smd0", NULL};
        |                                 ^~~~~~
2020-01-30 11:59:14 +01:00
Aleksander Morgado
db45ba60c1 broadband-modem: fix warnings with -Wimplicit-fallthrough
mm-broadband-modem.c: In function ‘disabling_step’:
  mm-broadband-modem.c:10498:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
  10498 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-broadband-modem.c:10500:5: note: here
  10500 |     case DISABLING_STEP_WAIT_FOR_FINAL_STATE:
        |     ^~~~
  ...
2020-01-30 11:59:14 +01:00
Aleksander Morgado
91ce5e9a68 broadband-modem: remove unused method
The logic in open_ports_initialization() was included in the generic
ports_context_open() method, and the method was not being used anywhere.
2020-01-30 11:59:14 +01:00
Aleksander Morgado
b1e0df4f24 broadband-modem: fix warnings with -Wsign-compare
mm-broadband-modem.c: In function ‘setup_ports’:
  mm-broadband-modem.c:9955:23: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare]
   9955 |         for (j = 0; j < array->len; j++) {
        |                       ^
  ...
2020-01-30 11:59:14 +01:00
Aleksander Morgado
51ef497634 port-probe: fix warnings with -Wdiscarded-qualifiers
mm-port-probe.c:1091:7: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
   1091 |     { "AT",  3, mm_port_probe_response_processor_is_at },
        |       ^~~~
  ...
2020-01-30 11:59:14 +01:00
Aleksander Morgado
337e5e96e0 broadband-modem: rework +CIEV URC handling
Switch to use the helper methods to parse strings and numbers from
match info results.

Also, avoid warnings with -Wsign-compare.
2020-01-30 11:59:14 +01:00
Aleksander Morgado
f0377d6e36 broadband-modem: fix warnings with -Wswitch-default
mm-broadband-modem.c: In function ‘access_tech_and_mask_new’:
  mm-broadband-modem.c:2431:9: error: switch missing default case [-Werror=switch-default]
   2431 |         switch (ctx->sysmode) {
        |         ^~~~~~
2020-01-30 11:59:14 +01:00
Aleksander Morgado
91216cb884 broadband-modem: fix warnings with -Wswitch-enum
mm-broadband-modem.c: In function ‘cgev_process_detach’:
  mm-broadband-modem.c:2845:5: error: enumeration value ‘MM_3GPP_CGEV_UNKNOWN’ not handled in switch [-Werror=switch-enum]
   2845 |     switch (type) {
        |     ^~~~~~
  ...
2020-01-30 11:59:14 +01:00
Aleksander Morgado
517862be35 broadband-modem: plug memleak if mm_parse_csim_response() fails
The GError would be leaking.
2020-01-30 11:59:14 +01:00
Aleksander Morgado
d5b30be6de broadband-modem: fix warnings with -Wdiscarded-qualifiers
mm-broadband-modem.c: At top level:
  mm-broadband-modem.c:551:7: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
    551 |     { "+CGSM",     MM_MODEM_CAPABILITY_GSM_UMTS  },
        |       ^~~~~~~
  ...
2020-01-30 11:59:14 +01:00
Aleksander Morgado
cf86e94b8a broadband-modem: fix warnings with -Wshadow
mm-broadband-modem.c: In function ‘modem_create_bearer’:
  mm-broadband-modem.c:421:42: error: declaration of ‘properties’ shadows a global declaration [-Werror=shadow]
    421 |                      MMBearerProperties *properties,
        |                      ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
  mm-broadband-modem.c:132:20: note: shadowed declaration is here
    132 | static GParamSpec *properties[PROP_LAST];
        |                    ^~~~~~~~~~
2020-01-30 11:59:14 +01:00
Aleksander Morgado
6887cfda71 iface-modem-oma: fix warnings with -Wimplicit-fallthrough
mm-iface-modem-oma.c: In function ‘interface_disabling_step’:
  mm-iface-modem-oma.c:732:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    732 |         ctx->step++;
        |         ~~~~~~~~~^~
  ...
2020-01-30 11:59:14 +01:00