colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform: fix memleak in link_delete()

Browse Source 
Turns out, the valgrind suppression was hiding a memleak
This commit is contained in:
Thomas Haller
2015-05-13 13:54:08 +02:00
parent 8e2ad8a3bd
commit 0c258402c7
2 changed files with 1 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/platform/nm-linux-platform.c
View File

@@ -2516,7 +2516,7 @@ static gboolean
link_delete (NMPlatform *platform, int ifindex) link_delete (NMPlatform *platform, int ifindex)
{ {
NMLinuxPlatformPrivate *priv = NM_LINUX_PLATFORM_GET_PRIVATE (platform); NMLinuxPlatformPrivate *priv = NM_LINUX_PLATFORM_GET_PRIVATE (platform);
struct rtnl_link *rtnllink = rtnl_link_get (priv->link_cache, ifindex); auto_nl_object struct rtnl_link *rtnllink = rtnl_link_get (priv->link_cache, ifindex);
if (!rtnllink) { if (!rtnllink) {
platform->error = NM_PLATFORM_ERROR_NOT_FOUND; platform->error = NM_PLATFORM_ERROR_NOT_FOUND;

16
valgrind.suppressions
View File

@@ -400,22 +400,6 @@
# libnl3 # libnl3
############################################################### ###############################################################
{
libnl_01
Memcheck:Leak
match-leak-kinds: definite
fun:calloc
fun:nl_object_alloc
fun:link_msg_parser
fun:__pickup_answer
fun:nl_cb_call
fun:recvmsgs
fun:nl_recvmsgs_report
fun:nl_recvmsgs
fun:nl_pickup
fun:rtnl_link_get_kernel
...
}
{ {
# fixed by https://github.com/thom311/libnl/commit/d65c32a7205e679c7fc13f0e4565b13e698ba906 # fixed by https://github.com/thom311/libnl/commit/d65c32a7205e679c7fc13f0e4565b13e698ba906
libnl_rtnl_link_set_type_01 libnl_rtnl_link_set_type_01