colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

core: be strict when parsing connection in AddAndActivateConnection

Browse Source 
AddAndActivateConnection is allowed to provide an incomplete connection
that will be completed by NetworkManager. That is, a connection that
does not verify.

But we still want to catch invalid properties or unknown setting types.
Thus, we want to reject invalid partial connections.

This possibly rejects invalid requests from clients that were accepted
before. Thus this change has the potential to break misbehaving clients.
This commit is contained in:
Thomas Haller
2016-03-23 16:12:12 +01:00
parent d4c201272e
commit 0c5b98b464
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/nm-manager.c
View File

@@ -3599,7 +3599,7 @@ impl_manager_add_and_activate_connection (NMManager *self,
*/ */
connection = nm_simple_connection_new (); connection = nm_simple_connection_new ();
if (settings && g_variant_n_children (settings)) if (settings && g_variant_n_children (settings))
nm_connection_replace_settings (connection, settings, NULL); _nm_connection_replace_settings (connection, settings, NM_SETTING_PARSE_FLAGS_STRICT, NULL);
subject = validate_activation_request (self, subject = validate_activation_request (self,
context, context,