diff --git a/NEWS b/NEWS index 301623636..bdf8b35d7 100644 --- a/NEWS +++ b/NEWS @@ -203,7 +203,7 @@ Overview of changes since NetworkManager-1.42 lead to unexpected behaviors in case of multiconnect profiles. * Set VLAN filtering options on bridge via netlink instead of sysfs. * nm-cloud-setup now supports IMDSv2 on Amazon EC2. -* nmtui now allows one to enable or disable Wi-Fi and WWAN radios. +* nmtui now supports enabling/disabling Wi-Fi and WWAN radios. * Honor ignore-carrier=no for bond/bridge/team devices. * Add version mismatch warning when running nmcli commands. diff --git a/contrib/fedora/rpm/build_clean.sh b/contrib/fedora/rpm/build_clean.sh index 68a6ffa41..402de4605 100755 --- a/contrib/fedora/rpm/build_clean.sh +++ b/contrib/fedora/rpm/build_clean.sh @@ -143,7 +143,7 @@ while [[ $# -gt 0 ]]; do ;; --no-auto-with-test) # by default, the script adds "-w test" (unless the command line contains - # "-w test" or "-W test"). This flags allows one to suppress that automatism. + # "-w test" or "-W test"). This flag suppresses that automatism. # It's really only useful to test the spec file's internal default for the # "test" option. Otherwise, you can always just explicitly select "-w test" # or "-W test". diff --git a/data/nm-priv-helper.service.in b/data/nm-priv-helper.service.in index b3f7701b2..d4ff25d9a 100644 --- a/data/nm-priv-helper.service.in +++ b/data/nm-priv-helper.service.in @@ -2,8 +2,8 @@ Description=NetworkManager Privileged Helper # -# nm-priv-helper exists for privilege separation. It allows one to run -# NetworkManager without certain capabilities, and ask nm-priv-helper +# nm-priv-helper exists for privilege separation. It allows NetworkManager +# to run without certain capabilities, and ask nm-priv-helper # for special operations where more privileges are required. # diff --git a/man/NetworkManager.conf.xml b/man/NetworkManager.conf.xml index 9ad5d7fb2..85f53b8e4 100644 --- a/man/NetworkManager.conf.xml +++ b/man/NetworkManager.conf.xml @@ -1374,7 +1374,7 @@ managed=1 scanning. This defaults to yes in which case a random, locally-administered MAC address will be used. The setting wifi.scan-generate-mac-address-mask - allows one to influence the generated MAC address to use certain vendor + can be used to influence the generated MAC address to use certain vendor OUIs. If disabled, the MAC address during scanning is left unchanged to whatever is configured. @@ -1398,7 +1398,7 @@ managed=1 Like the per-connection settings ethernet.generate-mac-address-mask - and wifi.generate-mac-address-mask, this allows one to configure the + and wifi.generate-mac-address-mask, this can be used to configure the generated MAC addresses during scanning. See nm-settings-nmcli5 for details. diff --git a/man/nm-cloud-setup.xml b/man/nm-cloud-setup.xml index f63ae50ad..af98b592f 100644 --- a/man/nm-cloud-setup.xml +++ b/man/nm-cloud-setup.xml @@ -115,9 +115,9 @@ nm-cloud-setup.service systemd unit Usually /usr/libexec/nm-cloud-setup is not run directly, but only by systemctl restart nm-cloud-setup.service. This - ensures that the tool only runs once at any time. It also allows one to integrate - with the nm-cloud-setup systemd timer, - and to enable/disable the service via systemd. + ensures that the tool only runs once at any time. + The unit is also used by the nm-cloud-setup systemd timer and allows + enabling/disabling the service via systemd. As you need to set environment variable to configure nm-cloud-setup binary, you can do so via systemd override files. Try systemctl edit nm-cloud-setup.service. diff --git a/src/contrib/nm-vpn-editor-plugin-call.h b/src/contrib/nm-vpn-editor-plugin-call.h index c6efce133..2f6820af8 100644 --- a/src/contrib/nm-vpn-editor-plugin-call.h +++ b/src/contrib/nm-vpn-editor-plugin-call.h @@ -11,7 +11,7 @@ * * This uses the NMVpnEditorPluginVT and allows a user (nm-applet) * to directly communicate with a VPN plugin using API that is newer - * then the current libnm version. That is, it allows one to call to a VPN + * then the current libnm version. That is, it allows a user to call to a VPN * plugin bypassing libnm. */ #include diff --git a/src/core/devices/nm-device-bond.c b/src/core/devices/nm-device-bond.c index 174f55476..0915e9156 100644 --- a/src/core/devices/nm-device-bond.c +++ b/src/core/devices/nm-device-bond.c @@ -902,7 +902,7 @@ reapply_connection(NMDevice *device, NMConnection *con_old, NMConnection *con_ne mode = _nm_setting_bond_mode_from_string(value); g_return_if_fail(mode != NM_BOND_MODE_UNKNOWN); - /* Below we set only the bond options that kernel allows one to modify + /* Below we set only the bond options that the kernel allows modifying * while keeping the bond interface up */ set_bond_arp_ip_targets(device, s_bond); diff --git a/src/core/dhcp/nm-dhcp-systemd.c b/src/core/dhcp/nm-dhcp-systemd.c index 4bb33d403..b570f7e50 100644 --- a/src/core/dhcp/nm-dhcp-systemd.c +++ b/src/core/dhcp/nm-dhcp-systemd.c @@ -395,7 +395,7 @@ ip6_start(NMDhcpClient *client, const struct in6_addr *ll_addr, GError **error) prefix_delegation = FALSE; if (client_config->v6.needed_prefixes > 0) { if (client_config->v6.needed_prefixes > 1) { - /* FIXME: systemd-networkd API only allows one to request a + /* FIXME: systemd-networkd API only allows requesting a * single prefix */ _LOGW("dhcp-client6: only one prefix request is supported"); } diff --git a/src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c b/src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c index 3d7f45979..1e2e2d92c 100644 --- a/src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c +++ b/src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c @@ -1439,7 +1439,7 @@ next:; : "")); break; case PARSE_LINE_TYPE_FLAG: - /* NOTE: the flag (for "onlink") only allows one to explicitly set "TRUE". + /* NOTE: the flag (for "onlink") only allows setting "TRUE" explicitly. * There is no way to express an explicit "FALSE" setting * of this attribute, hence, the file format cannot encode * that configuration. */ diff --git a/src/libnm-core-impl/nm-setting-connection.c b/src/libnm-core-impl/nm-setting-connection.c index f22499a4f..4829dcdcd 100644 --- a/src/libnm-core-impl/nm-setting-connection.c +++ b/src/libnm-core-impl/nm-setting-connection.c @@ -2533,7 +2533,7 @@ nm_setting_connection_class_init(NMSettingConnectionClass *klass) * NMSettingConnection:stable-id: * * This represents the identity of the connection used for various purposes. - * It allows one to configure multiple profiles to share the identity. Also, + * It allows configuring multiple profiles to share the identity. Also, * the stable-id can contain placeholders that are substituted dynamically and * deterministically depending on the context. * diff --git a/src/libnm-core-impl/nm-setting-ovs-other-config.c b/src/libnm-core-impl/nm-setting-ovs-other-config.c index d889d1f4a..392fc46b1 100644 --- a/src/libnm-core-impl/nm-setting-ovs-other-config.c +++ b/src/libnm-core-impl/nm-setting-ovs-other-config.c @@ -19,8 +19,8 @@ * SECTION:nm-setting-ovs-other-config * @short_description: Other-config settings for OVS * - * The #NMSettingOvsOtherConfig object is a #NMSetting subclass that allows one to - * configure other_config settings for OVS. See also "other_config" in the + * The #NMSettingOvsOtherConfig object is a #NMSetting subclass that specifies + * "other_config" settings for OVS. See also "other_config" in the * "ovs-vswitchd.conf.db" manual for the keys that OVS supports. **/