colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wifi: fix some warnings caused by hidden SSID patches (23a5ae2f) (rh #1069844)

Browse Source 
It could also cause nm_device_connection_is_available() to return TRUE
for wifi devices, for connections that were not wifi.
This commit is contained in:
Dan Williams
2014-03-13 10:59:02 -05:00
parent b02353e954
commit 11d8f21b68
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/devices/nm-device-wifi.c
View File

@@ -1060,6 +1060,9 @@ _internal_check_connection_available (NMDevice *device,
const char *mode; const char *mode;
GSList *ap_iter = NULL; GSList *ap_iter = NULL;
s_wifi = nm_connection_get_setting_wireless (connection);
g_return_val_if_fail (s_wifi, FALSE);
if (specific_object) { if (specific_object) {
NMAccessPoint *ap; NMAccessPoint *ap;
@@ -1067,8 +1070,6 @@ _internal_check_connection_available (NMDevice *device,
return ap ? nm_ap_check_compatible (ap, connection) : FALSE; return ap ? nm_ap_check_compatible (ap, connection) : FALSE;
} }
s_wifi = nm_connection_get_setting_wireless (connection);
/* Ad-Hoc and AP connections are always available because they may be /* Ad-Hoc and AP connections are always available because they may be
* started at any time. * started at any time.
*/ */

3
src/devices/nm-device.c
View File

@@ -7177,7 +7177,8 @@ nm_device_connection_is_available (NMDevice *device,
* activating but the network isn't available let the device recheck * activating but the network isn't available let the device recheck
* availability. * availability.
*/ */
if (NM_DEVICE_GET_CLASS (device)->check_connection_available_wifi_hidden) if ( nm_device_check_connection_compatible (device, connection, NULL)
&& NM_DEVICE_GET_CLASS (device)->check_connection_available_wifi_hidden)
available = NM_DEVICE_GET_CLASS (device)->check_connection_available_wifi_hidden (device, connection); available = NM_DEVICE_GET_CLASS (device)->check_connection_available_wifi_hidden (device, connection);
} }