colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform: avoid coverity warning about not checking nla_nest_start() result

Browse Source 
Usually we check the result of nla_nest_start(). Also, in most cases where this
function would return %NULL, it's an actual bug. That is, because our netlink
message is allocated with a large buffer, and in most cases we append there a well
known, small amount of data.

To make coverity happy, handle the case and assert.
This commit is contained in:
Thomas Haller
2019-08-01 17:48:48 +02:00
parent 026739eb9f
commit 243458836a
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/platform/wifi/nm-wifi-utils-nl80211.c
View File

@@ -347,6 +347,8 @@ wifi_nl80211_set_wake_on_wlan (NMWifiUtils *data, NMSettingWirelessWakeOnWLan wo
return FALSE; return FALSE;
triggers = nla_nest_start (msg, NL80211_ATTR_WOWLAN_TRIGGERS); triggers = nla_nest_start (msg, NL80211_ATTR_WOWLAN_TRIGGERS);
if (!triggers)
goto nla_put_failure;
if (NM_FLAGS_HAS (wowl, NM_SETTING_WIRELESS_WAKE_ON_WLAN_ANY)) if (NM_FLAGS_HAS (wowl, NM_SETTING_WIRELESS_WAKE_ON_WLAN_ANY))
NLA_PUT_FLAG (msg, NL80211_WOWLAN_TRIG_ANY); NLA_PUT_FLAG (msg, NL80211_WOWLAN_TRIG_ANY);