colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wwan/ofono: correct MMS proxy property lookup

Browse Source 
The property name under `Settings` dict is just `Proxy`, unlike the one
outside which is `MessageProxy`. See [1].

[1] https://kernel.googlesource.com/pub/scm/network/ofono/ofono/+/refs/heads/master/doc/connman-api.txt#253

Fixes: a6e81af87f ('wwan: add support for using oFono as a modem manager')
This commit is contained in:
Ratchanan Srirattanamet
2023-03-25 03:20:11 +07:00
committed by Thomas Haller
parent c4aa969a43
commit 264fed4778
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/devices/wwan/nm-modem-ofono.c
View File

@@ -1320,8 +1320,8 @@ handle_settings(NMModemOfono *self, GVariant *v_dict)
} }
} }
if (g_variant_lookup(v_dict, "MessageProxy", "&s", &s)) { if (g_variant_lookup(v_dict, "Proxy", "&s", &s)) {
_LOGI("MessageProxy: %s", s); _LOGI("(MMS) Proxy: %s", s);
if (s && nm_inet_parse_bin(AF_INET, s, NULL, &address_network)) { if (s && nm_inet_parse_bin(AF_INET, s, NULL, &address_network)) {
const NMPlatformIP4Route mms_route = { const NMPlatformIP4Route mms_route = {
.network = address_network, .network = address_network,
@@ -1335,7 +1335,7 @@ handle_settings(NMModemOfono *self, GVariant *v_dict)
nm_l3_config_data_add_route_4(priv->l3cd_4, &mms_route); nm_l3_config_data_add_route_4(priv->l3cd_4, &mms_route);
} else } else
_LOGW("invalid MessageProxy: %s", s); _LOGW("invalid (MMS) Proxy: %s", s);
} }
ret = TRUE; ret = TRUE;