colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

logging: prefer stack buffer for logging message

Browse Source
This commit is contained in:
Thomas Haller
2021-01-14 11:43:56 +01:00
parent 45ba49f322
commit 29e93b1738
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/libnm-log-core/nm-logging.c
View File

@@ -656,8 +656,9 @@ _nm_log_impl(const char *file,
const char *fmt, const char *fmt,
...) ...)
{ {
va_list args; char msg_stack[400];
char * msg; gs_free char * msg_heap = NULL;
const char * msg;
GTimeVal tv; GTimeVal tv;
int errsv; int errsv;
const NMLogDomain *cur_log_state; const NMLogDomain *cur_log_state;
@@ -698,9 +699,7 @@ _nm_log_impl(const char *file,
errno = error; errno = error;
} }
va_start(args, fmt); msg = nm_vsprintf_buf_or_alloc(fmt, fmt, msg_stack, &msg_heap, NULL);
msg = g_strdup_vprintf(fmt, args);
va_end(args);
#define MESSAGE_FMT "%s%-7s [%ld.%04ld] %s" #define MESSAGE_FMT "%s%-7s [%ld.%04ld] %s"
#define MESSAGE_ARG(prefix, tv, msg) \ #define MESSAGE_ARG(prefix, tv, msg) \
@@ -797,8 +796,6 @@ _nm_log_impl(const char *file,
break; break;
} }
g_free(msg);
errno = errsv; errno = errsv;
} }