colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

core: avoid use-after-free in libnm-util/bond.verify()

Browse Source 
Signed-off-by: Thomas Haller <thaller@redhat.com>
This commit is contained in:
Thomas Haller
2013-10-08 22:22:00 +02:00
parent e9a362ba65
commit 2b25d0d3e0
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libnm-util/nm-setting-bond.c
View File

@@ -540,25 +540,25 @@ verify (NMSetting *setting, GSList *all_settings, GError **error)
addrs = g_strsplit (arp_ip_target, ",", -1); addrs = g_strsplit (arp_ip_target, ",", -1);
if (!addrs[0]) { if (!addrs[0]) {
g_strfreev (addrs);
g_set_error (error, g_set_error (error,
NM_SETTING_BOND_ERROR, NM_SETTING_BOND_ERROR,
NM_SETTING_BOND_ERROR_INVALID_OPTION, NM_SETTING_BOND_ERROR_INVALID_OPTION,
_("'%s' option is empty"), _("'%s' option is empty"),
NM_SETTING_BOND_OPTION_ARP_IP_TARGET); NM_SETTING_BOND_OPTION_ARP_IP_TARGET);
g_prefix_error (error, "%s.%s: ", NM_SETTING_BOND_SETTING_NAME, NM_SETTING_BOND_OPTIONS); g_prefix_error (error, "%s.%s: ", NM_SETTING_BOND_SETTING_NAME, NM_SETTING_BOND_OPTIONS);
g_strfreev (addrs);
return FALSE; return FALSE;
} }
for (i = 0; addrs[i]; i++) { for (i = 0; addrs[i]; i++) {
if (!inet_pton (AF_INET, addrs[i], &addr)) { if (!inet_pton (AF_INET, addrs[i], &addr)) {
g_strfreev (addrs);
g_set_error (error, g_set_error (error,
NM_SETTING_BOND_ERROR, NM_SETTING_BOND_ERROR,
NM_SETTING_BOND_ERROR_INVALID_OPTION, NM_SETTING_BOND_ERROR_INVALID_OPTION,
_("'%s' is not a valid IPv4 address for '%s' option"), _("'%s' is not a valid IPv4 address for '%s' option"),
NM_SETTING_BOND_OPTION_ARP_IP_TARGET, addrs[i]); NM_SETTING_BOND_OPTION_ARP_IP_TARGET, addrs[i]);
g_prefix_error (error, "%s.%s: ", NM_SETTING_BOND_SETTING_NAME, NM_SETTING_BOND_OPTIONS); g_prefix_error (error, "%s.%s: ", NM_SETTING_BOND_SETTING_NAME, NM_SETTING_BOND_OPTIONS);
g_strfreev (addrs);
return FALSE; return FALSE;
} }
} }