proxy: reject huge pac_script values in verify()

2016-09-27 11:09:13 +02:00
parent 20098591d9
commit 2de000e1d2
1 changed files with 9 additions and 0 deletions
--- a/libnm-core/nm-setting-proxy.c
+++ b/libnm-core/nm-setting-proxy.c
@@ -173,6 +173,15 @@ verify (NMSetting *setting, NMConnection *connection, GError **error)
 		}
 	}

+	if (priv->pac_script && strlen (priv->pac_script) > 1*1024*1024) {
+		g_set_error (error,
+		             NM_CONNECTION_ERROR,
+		             NM_CONNECTION_ERROR_INVALID_PROPERTY,
+		             _("the script is too large"));
+		g_prefix_error (error, "%s.%s: ", NM_SETTING_PROXY_SETTING_NAME, NM_SETTING_PROXY_PAC_SCRIPT);
+		return FALSE;
+	}
+
 	return TRUE;
 }