colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ovs-interface: dissociate the link on disconnection

Browse Source 
Open vSwitch is the special kid on the block -- it likes to be in charge of
the link lifetime and so we shouldn't be. This means that we shouldn't be
attempting to remove the link: we'd just (gracefully) fail anyways.

More importantly, this also means that we shouldn't care if we see the link
go away. Once the device reaches DISCONNECTED state, its configuration is
cleaned up and we may already be activating another connection. We shouldn't
alter the device state when OpenVSwitch decides to drop the old link.

https://bugzilla.redhat.com/show_bug.cgi?id=1543557
https://github.com/NetworkManager/NetworkManager/pull/324
This commit is contained in:
Lubomir Rintel
2019-03-12 15:50:47 +01:00
parent f034f17ff6
commit 3a55ec63e1
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/devices/ovs/nm-device-ovs-interface.c
View File

@@ -118,6 +118,16 @@ link_changed (NMDevice *device,
} }
} }
static void
state_changed (NMDevice *device,
NMDeviceState new_state,
NMDeviceState old_state,
NMDeviceStateReason reason)
{
if (new_state <= NM_DEVICE_STATE_DISCONNECTED)
nm_device_update_from_platform_link (device, NULL);
}
static gboolean static gboolean
_is_internal_interface (NMDevice *device) _is_internal_interface (NMDevice *device)
{ {
@@ -190,6 +200,7 @@ nm_device_ovs_interface_class_init (NMDeviceOvsInterfaceClass *klass)
device_class->is_available = is_available; device_class->is_available = is_available;
device_class->check_connection_compatible = check_connection_compatible; device_class->check_connection_compatible = check_connection_compatible;
device_class->link_changed = link_changed; device_class->link_changed = link_changed;
device_class->state_changed = state_changed;
device_class->act_stage3_ip_config_start = act_stage3_ip_config_start; device_class->act_stage3_ip_config_start = act_stage3_ip_config_start;
device_class->can_unmanaged_external_down = can_unmanaged_external_down; device_class->can_unmanaged_external_down = can_unmanaged_external_down;
} }